[PATCH v1] input: tegra-kbc: Add Function keymap.

[PATCH v1] input: tegra-kbc: Add Function keymap.

[riyer]

From: Rakesh Iyer <riyer@nvidia.com>

Add Fn keymap support to allow for internal processing of Fn keys.

Signed-off-by: Rakesh Iyer <riyer@nvidia.com>
---
Added support for Fn keymap within tegra keyboard driver.

 arch/arm/mach-tegra/include/mach/kbc.h |    1 +
 drivers/input/keyboard/tegra-kbc.c     |   50 ++++++++++++++++++++++++++++++--
 2 files changed, 48 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-tegra/include/mach/kbc.h b/arch/arm/mach-tegra/include/mach/kbc.h
index 66ad276..04c7798 100644
--- a/arch/arm/mach-tegra/include/mach/kbc.h
+++ b/arch/arm/mach-tegra/include/mach/kbc.h
@@ -57,5 +57,6 @@ struct tegra_kbc_platform_data {
 	const struct matrix_keymap_data *keymap_data;
 
 	bool wakeup;
+	bool use_fn_map;
 };
 #endif
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index ac471b7..9f7bd2e 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -60,7 +60,7 @@
 #define KBC_KP_ENT1_0	0x34
 #define KBC_ROW0_MASK_0	0x38
 
-#define KBC_ROW_SHIFT	3
+#define KBC_ROW_SHIFT	4
 
 struct tegra_kbc {
 	void __iomem *mmio;
@@ -71,8 +71,9 @@ struct tegra_kbc {
 	spinlock_t lock;
 	unsigned int repoll_dly;
 	unsigned long cp_dly_jiffies;
+	bool use_fn_map;
 	const struct tegra_kbc_platform_data *pdata;
-	unsigned short keycode[KBC_MAX_KEY];
+	unsigned short keycode[KBC_MAX_KEY * 2];
 	unsigned short current_keys[KBC_MAX_KPENT];
 	unsigned int num_pressed_keys;
 	struct timer_list timer;
@@ -107,6 +108,7 @@ static const u32 tegra_kbc_default_keymap[] = {
 	KEY(4, 5, KEY_V),
 	KEY(4, 6, KEY_C),
 	KEY(4, 7, KEY_SPACE),
+	KEY(4, 8, KEY_7),
 
 	KEY(5, 0, KEY_9),
 	KEY(5, 1, KEY_8),
@@ -116,6 +118,10 @@ static const u32 tegra_kbc_default_keymap[] = {
 	KEY(5, 5, KEY_N),
 	KEY(5, 6, KEY_B),
 	KEY(5, 7, KEY_BACKSLASH),
+	KEY(5, 8, KEY_9),
+	KEY(5, 9, KEY_8),
+	KEY(5, 10, KEY_4),
+	KEY(5, 12, KEY_1),
 
 	KEY(6, 0, KEY_MINUS),
 	KEY(6, 1, KEY_0),
@@ -125,6 +131,12 @@ static const u32 tegra_kbc_default_keymap[] = {
 	KEY(6, 5, KEY_K),
 	KEY(6, 6, KEY_COMMA),
 	KEY(6, 7, KEY_M),
+	KEY(6, 9, KEY_SLASH),
+	KEY(6, 10, KEY_6),
+	KEY(6, 11, KEY_5),
+	KEY(6, 12, KEY_3),
+	KEY(6, 13, KEY_2),
+	KEY(6, 15, KEY_0),
 
 	KEY(7, 1, KEY_EQUAL),
 	KEY(7, 2, KEY_RIGHTBRACE),
@@ -143,6 +155,10 @@ static const u32 tegra_kbc_default_keymap[] = {
 	KEY(11, 3, KEY_SEMICOLON),
 	KEY(11, 4, KEY_SLASH),
 	KEY(11, 5, KEY_DOT),
+	KEY(11, 9, KEY_KPASTERISK),
+	KEY(11, 11, KEY_KPMINUS),
+	KEY(11, 12, KEY_KPPLUS),
+	KEY(11, 13, KEY_DOT),
 
 	KEY(12, 0, KEY_F10),
 	KEY(12, 1, KEY_F9),
@@ -152,6 +168,7 @@ static const u32 tegra_kbc_default_keymap[] = {
 	KEY(12, 5, KEY_UP),
 	KEY(12, 6, KEY_PRINT),
 	KEY(12, 7, KEY_PAUSE),
+	KEY(12, 13, KEY_VOLUMEUP),
 
 	KEY(13, 0, KEY_INSERT),
 	KEY(13, 1, KEY_DELETE),
@@ -160,6 +177,11 @@ static const u32 tegra_kbc_default_keymap[] = {
 	KEY(13, 5, KEY_RIGHT),
 	KEY(13, 6, KEY_DOWN),
 	KEY(13, 7, KEY_LEFT),
+	KEY(13, 11, KEY_HOME),
+	KEY(13, 12, KEY_END),
+	KEY(13, 13, KEY_BRIGHTNESSDOWN),
+	KEY(13, 14, KEY_VOLUMEDOWN),
+	KEY(13, 15, KEY_BRIGHTNESSUP),
 
 	KEY(14, 0, KEY_F11),
 	KEY(14, 1, KEY_F12),
@@ -169,6 +191,9 @@ static const u32 tegra_kbc_default_keymap[] = {
 	KEY(14, 5, KEY_F3),
 	KEY(14, 6, KEY_1),
 	KEY(14, 7, KEY_F7),
+	KEY(14, 8, KEY_NUMLOCK),
+	KEY(14, 9, KEY_SCROLLLOCK),
+	KEY(14, 10, KEY_MUTE),
 
 	KEY(15, 0, KEY_ESC),
 	KEY(15, 1, KEY_GRAVE),
@@ -178,6 +203,7 @@ static const u32 tegra_kbc_default_keymap[] = {
 	KEY(15, 5, KEY_F2),
 	KEY(15, 6, KEY_CAPSLOCK),
 	KEY(15, 7, KEY_F6),
+	KEY(15, 12, KEY_QUESTION),
 };
 
 static const struct matrix_keymap_data tegra_kbc_default_keymap_data = {
@@ -224,6 +250,7 @@ static void tegra_kbc_report_keys(struct tegra_kbc *kbc)
 	unsigned int i;
 	unsigned int num_down = 0;
 	unsigned long flags;
+	bool fn_keypress = false;
 
 	spin_lock_irqsave(&kbc->lock, flags);
 	for (i = 0; i < KBC_MAX_KPENT; i++) {
@@ -237,11 +264,26 @@ static void tegra_kbc_report_keys(struct tegra_kbc *kbc)
 				MATRIX_SCAN_CODE(row, col, KBC_ROW_SHIFT);
 
 			scancodes[num_down] = scancode;
-			keycodes[num_down++] = kbc->keycode[scancode];
+			keycodes[num_down] = kbc->keycode[scancode];
+			/* If driver uses Fn map, do not report the Fn key. */
+			if ((keycodes[num_down] == KEY_FN) && kbc->use_fn_map)
+				fn_keypress = true;
+			else
+				num_down++;
 		}
 
 		val >>= 8;
 	}
+
+	/*
+	 * If the platform uses Fn keymaps, translate keys on a Fn keypress.
+	 * Function keycodes are KBC_MAX_COL apart from the plain keycodes.
+	 */
+	for (i = 0; (i < num_down) && fn_keypress; i++) {
+		scancodes[i] += KBC_MAX_COL;
+		keycodes[i] = kbc->keycode[scancodes[i]];
+	}
+
 	spin_unlock_irqrestore(&kbc->lock, flags);
 
 	tegra_kbc_report_released_keys(kbc->idev,
@@ -596,9 +638,11 @@ static int __devinit tegra_kbc_probe(struct platform_device *pdev)
 	input_dev->keycodesize = sizeof(kbc->keycode[0]);
 	input_dev->keycodemax = ARRAY_SIZE(kbc->keycode);
 
+	/* The driver keymap requires internal processing of Fn keys. */
 	keymap_data = pdata->keymap_data ?: &tegra_kbc_default_keymap_data;
 	matrix_keypad_build_keymap(keymap_data, KBC_ROW_SHIFT,
 				   input_dev->keycode, input_dev->keybit);
+	kbc->use_fn_map = pdata->keymap_data ? pdata->use_fn_map : true;
 
 	err = request_irq(kbc->irq, tegra_kbc_isr, IRQF_TRIGGER_HIGH,
 			  pdev->name, kbc);
-- 
1.7.0.4


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Re: [PATCH v1] input: tegra-kbc: Add Function keymap.

[Dmitry Torokhov]

On Tue, Feb 08, 2011 at 12:56:24PM -0800, riyer@nvidia.com wrote:
> From: Rakesh Iyer <riyer@nvidia.com>
> 
> Add Fn keymap support to allow for internal processing of Fn keys.
> 
> Signed-off-by: Rakesh Iyer <riyer@nvidia.com>
> ---
> Added support for Fn keymap within tegra keyboard driver.
> 
>  arch/arm/mach-tegra/include/mach/kbc.h |    1 +
>  drivers/input/keyboard/tegra-kbc.c     |   50 ++++++++++++++++++++++++++++++--
>  2 files changed, 48 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-tegra/include/mach/kbc.h b/arch/arm/mach-tegra/include/mach/kbc.h
> index 66ad276..04c7798 100644
> --- a/arch/arm/mach-tegra/include/mach/kbc.h
> +++ b/arch/arm/mach-tegra/include/mach/kbc.h
> @@ -57,5 +57,6 @@ struct tegra_kbc_platform_data {
>  	const struct matrix_keymap_data *keymap_data;
>  
>  	bool wakeup;
> +	bool use_fn_map;
>  };
>  #endif
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index ac471b7..9f7bd2e 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -60,7 +60,7 @@
>  #define KBC_KP_ENT1_0	0x34
>  #define KBC_ROW0_MASK_0	0x38
>  
> -#define KBC_ROW_SHIFT	3
> +#define KBC_ROW_SHIFT	4
>  
>  struct tegra_kbc {
>  	void __iomem *mmio;
> @@ -71,8 +71,9 @@ struct tegra_kbc {
>  	spinlock_t lock;
>  	unsigned int repoll_dly;
>  	unsigned long cp_dly_jiffies;
> +	bool use_fn_map;
>  	const struct tegra_kbc_platform_data *pdata;
> -	unsigned short keycode[KBC_MAX_KEY];
> +	unsigned short keycode[KBC_MAX_KEY * 2];
>  	unsigned short current_keys[KBC_MAX_KPENT];
>  	unsigned int num_pressed_keys;
>  	struct timer_list timer;
> @@ -107,6 +108,7 @@ static const u32 tegra_kbc_default_keymap[] = {
>  	KEY(4, 5, KEY_V),
>  	KEY(4, 6, KEY_C),
>  	KEY(4, 7, KEY_SPACE),
> +	KEY(4, 8, KEY_7),
>  
>  	KEY(5, 0, KEY_9),
>  	KEY(5, 1, KEY_8),
> @@ -116,6 +118,10 @@ static const u32 tegra_kbc_default_keymap[] = {
>  	KEY(5, 5, KEY_N),
>  	KEY(5, 6, KEY_B),
>  	KEY(5, 7, KEY_BACKSLASH),
> +	KEY(5, 8, KEY_9),
> +	KEY(5, 9, KEY_8),
> +	KEY(5, 10, KEY_4),
> +	KEY(5, 12, KEY_1),

I think Fn emulates keypad here, so KEY_KP9, KEY_KP8, etc.

>  
>  	KEY(6, 0, KEY_MINUS),
>  	KEY(6, 1, KEY_0),
> @@ -125,6 +131,12 @@ static const u32 tegra_kbc_default_keymap[] = {
>  	KEY(6, 5, KEY_K),
>  	KEY(6, 6, KEY_COMMA),
>  	KEY(6, 7, KEY_M),
> +	KEY(6, 9, KEY_SLASH),
> +	KEY(6, 10, KEY_6),
> +	KEY(6, 11, KEY_5),
> +	KEY(6, 12, KEY_3),
> +	KEY(6, 13, KEY_2),
> +	KEY(6, 15, KEY_0),
>  
>  	KEY(7, 1, KEY_EQUAL),
>  	KEY(7, 2, KEY_RIGHTBRACE),
> @@ -143,6 +155,10 @@ static const u32 tegra_kbc_default_keymap[] = {
>  	KEY(11, 3, KEY_SEMICOLON),
>  	KEY(11, 4, KEY_SLASH),
>  	KEY(11, 5, KEY_DOT),
> +	KEY(11, 9, KEY_KPASTERISK),
> +	KEY(11, 11, KEY_KPMINUS),
> +	KEY(11, 12, KEY_KPPLUS),
> +	KEY(11, 13, KEY_DOT),
>  
>  	KEY(12, 0, KEY_F10),
>  	KEY(12, 1, KEY_F9),
> @@ -152,6 +168,7 @@ static const u32 tegra_kbc_default_keymap[] = {
>  	KEY(12, 5, KEY_UP),
>  	KEY(12, 6, KEY_PRINT),
>  	KEY(12, 7, KEY_PAUSE),
> +	KEY(12, 13, KEY_VOLUMEUP),
>  
>  	KEY(13, 0, KEY_INSERT),
>  	KEY(13, 1, KEY_DELETE),
> @@ -160,6 +177,11 @@ static const u32 tegra_kbc_default_keymap[] = {
>  	KEY(13, 5, KEY_RIGHT),
>  	KEY(13, 6, KEY_DOWN),
>  	KEY(13, 7, KEY_LEFT),
> +	KEY(13, 11, KEY_HOME),
> +	KEY(13, 12, KEY_END),
> +	KEY(13, 13, KEY_BRIGHTNESSDOWN),
> +	KEY(13, 14, KEY_VOLUMEDOWN),
> +	KEY(13, 15, KEY_BRIGHTNESSUP),
>  
>  	KEY(14, 0, KEY_F11),
>  	KEY(14, 1, KEY_F12),
> @@ -169,6 +191,9 @@ static const u32 tegra_kbc_default_keymap[] = {
>  	KEY(14, 5, KEY_F3),
>  	KEY(14, 6, KEY_1),
>  	KEY(14, 7, KEY_F7),
> +	KEY(14, 8, KEY_NUMLOCK),
> +	KEY(14, 9, KEY_SCROLLLOCK),
> +	KEY(14, 10, KEY_MUTE),
>  
>  	KEY(15, 0, KEY_ESC),
>  	KEY(15, 1, KEY_GRAVE),
> @@ -178,6 +203,7 @@ static const u32 tegra_kbc_default_keymap[] = {
>  	KEY(15, 5, KEY_F2),
>  	KEY(15, 6, KEY_CAPSLOCK),
>  	KEY(15, 7, KEY_F6),
> +	KEY(15, 12, KEY_QUESTION),

Not KEY_SLASH or similar?

-- 
Dmitry

RE: [PATCH v1] input: tegra-kbc: Add Function keymap.

[Rakesh Iyer]

> >  	KEY(6, 0, KEY_MINUS),
> >  	KEY(6, 1, KEY_0),
> > @@ -125,6 +131,12 @@ static const u32 tegra_kbc_default_keymap[] = {
> >  	KEY(6, 5, KEY_K),
> >  	KEY(6, 6, KEY_COMMA),
> >  	KEY(6, 7, KEY_M),
> > +	KEY(6, 9, KEY_SLASH),
> > +	KEY(6, 10, KEY_6),
> > +	KEY(6, 11, KEY_5),
> > +	KEY(6, 12, KEY_3),
> > +	KEY(6, 13, KEY_2),
> > +	KEY(6, 15, KEY_0),
> >
> >  	KEY(7, 1, KEY_EQUAL),
> >  	KEY(7, 2, KEY_RIGHTBRACE),
> > @@ -143,6 +155,10 @@ static const u32 tegra_kbc_default_keymap[] = {
> >  	KEY(11, 3, KEY_SEMICOLON),
> >  	KEY(11, 4, KEY_SLASH),
> >  	KEY(11, 5, KEY_DOT),
> > +	KEY(11, 9, KEY_KPASTERISK),
> > +	KEY(11, 11, KEY_KPMINUS),
> > +	KEY(11, 12, KEY_KPPLUS),
> > +	KEY(11, 13, KEY_DOT),
> >
> >  	KEY(12, 0, KEY_F10),
> >  	KEY(12, 1, KEY_F9),
> > @@ -152,6 +168,7 @@ static const u32 tegra_kbc_default_keymap[] = {
> >  	KEY(12, 5, KEY_UP),
> >  	KEY(12, 6, KEY_PRINT),
> >  	KEY(12, 7, KEY_PAUSE),
> > +	KEY(12, 13, KEY_VOLUMEUP),
> >
> >  	KEY(13, 0, KEY_INSERT),
> >  	KEY(13, 1, KEY_DELETE),
> > @@ -160,6 +177,11 @@ static const u32 tegra_kbc_default_keymap[] = {
> >  	KEY(13, 5, KEY_RIGHT),
> >  	KEY(13, 6, KEY_DOWN),
> >  	KEY(13, 7, KEY_LEFT),
> > +	KEY(13, 11, KEY_HOME),
> > +	KEY(13, 12, KEY_END),
> > +	KEY(13, 13, KEY_BRIGHTNESSDOWN),
> > +	KEY(13, 14, KEY_VOLUMEDOWN),
> > +	KEY(13, 15, KEY_BRIGHTNESSUP),
> >
> >  	KEY(14, 0, KEY_F11),
> >  	KEY(14, 1, KEY_F12),
> > @@ -169,6 +191,9 @@ static const u32 tegra_kbc_default_keymap[] = {
> >  	KEY(14, 5, KEY_F3),
> >  	KEY(14, 6, KEY_1),
> >  	KEY(14, 7, KEY_F7),
> > +	KEY(14, 8, KEY_NUMLOCK),
> > +	KEY(14, 9, KEY_SCROLLLOCK),
> > +	KEY(14, 10, KEY_MUTE),
> >
> >  	KEY(15, 0, KEY_ESC),
> >  	KEY(15, 1, KEY_GRAVE),
> > @@ -178,6 +203,7 @@ static const u32 tegra_kbc_default_keymap[] = {
> >  	KEY(15, 5, KEY_F2),
> >  	KEY(15, 6, KEY_CAPSLOCK),
> >  	KEY(15, 7, KEY_F6),
> > +	KEY(15, 12, KEY_QUESTION),
> 
> Not KEY_SLASH or similar?
> 
> --
> Dmitry

Actually in this keyboard layout that key indeed maps to KEY_QUESTION and not KEY_SLASH.
Is that unexpected.

Regards
Rakesh
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Re: [PATCH v1] input: tegra-kbc: Add Function keymap.

[Dmitry Torokhov]

On Wed, Feb 09, 2011 at 09:21:36AM -0800, Rakesh Iyer wrote:
> > >
> > >  	KEY(15, 0, KEY_ESC),
> > >  	KEY(15, 1, KEY_GRAVE),
> > > @@ -178,6 +203,7 @@ static const u32 tegra_kbc_default_keymap[] = {
> > >  	KEY(15, 5, KEY_F2),
> > >  	KEY(15, 6, KEY_CAPSLOCK),
> > >  	KEY(15, 7, KEY_F6),
> > > +	KEY(15, 12, KEY_QUESTION),
> > 
> > Not KEY_SLASH or similar?
> > 
> Actually in this keyboard layout that key indeed maps to KEY_QUESTION and not KEY_SLASH.
> Is that unexpected.
> 

So it is a dedicated key for a question mark? KEY_QUESTION is not really
that although we could re-purpose it (the USB keyboard that is currently
using this keycode most likely wants KEY_HELP or similar).

Is there a picture of physical keypad somewhere?

-- 
Dmitry

RE: [PATCH v1] input: tegra-kbc: Add Function keymap.

[Rakesh Iyer]

The following is a public image of the same keyboard we are using as default.

http://www.laptopguts.co.uk/ekmps/shops/laptopguts/images/acer-aspire-3690-series-laptop-keyboard-uk-layout-108-p[ekm]758x300[ekm].jpg

Regards
Rakesh
> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> Sent: Tuesday, February 15, 2011 10:55 AM
> To: Rakesh Iyer
> Cc: linux-input@vger.kernel.org; olofj@chromium.org; Andrew Chew
> Subject: Re: [PATCH v1] input: tegra-kbc: Add Function keymap.
> 
> On Wed, Feb 09, 2011 at 09:21:36AM -0800, Rakesh Iyer wrote:
> > > >
> > > >  	KEY(15, 0, KEY_ESC),
> > > >  	KEY(15, 1, KEY_GRAVE),
> > > > @@ -178,6 +203,7 @@ static const u32 tegra_kbc_default_keymap[] = {
> > > >  	KEY(15, 5, KEY_F2),
> > > >  	KEY(15, 6, KEY_CAPSLOCK),
> > > >  	KEY(15, 7, KEY_F6),
> > > > +	KEY(15, 12, KEY_QUESTION),
> > >
> > > Not KEY_SLASH or similar?
> > >
> > Actually in this keyboard layout that key indeed maps to KEY_QUESTION and not
> KEY_SLASH.
> > Is that unexpected.
> >
> 
> So it is a dedicated key for a question mark? KEY_QUESTION is not really
> that although we could re-purpose it (the USB keyboard that is currently
> using this keycode most likely wants KEY_HELP or similar).
> 
> Is there a picture of physical keypad somewhere?
> 
> --
> Dmitry
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

RE: [PATCH v1] input: tegra-kbc: Add Function keymap.

[Rakesh Iyer]

Just wanted to add  -> some of the keys on the extreme right are not present in our keyboard (Euro and Dollar) and some others such as PgUp, PgDown are laid out differently.

Regards
Rakesh


> -----Original Message-----
> From: Rakesh Iyer
> Sent: Tuesday, February 15, 2011 11:47 AM
> To: 'Dmitry Torokhov'
> Cc: linux-input@vger.kernel.org; olofj@chromium.org; Andrew Chew
> Subject: RE: [PATCH v1] input: tegra-kbc: Add Function keymap.
> 
> The following is a public image of the same keyboard we are using as default.
> 
> http://www.laptopguts.co.uk/ekmps/shops/laptopguts/images/acer-aspire-3690-series-laptop-
> keyboard-uk-layout-108-p[ekm]758x300[ekm].jpg
> 
> Regards
> Rakesh
> > -----Original Message-----
> > From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> > Sent: Tuesday, February 15, 2011 10:55 AM
> > To: Rakesh Iyer
> > Cc: linux-input@vger.kernel.org; olofj@chromium.org; Andrew Chew
> > Subject: Re: [PATCH v1] input: tegra-kbc: Add Function keymap.
> >
> > On Wed, Feb 09, 2011 at 09:21:36AM -0800, Rakesh Iyer wrote:
> > > > >
> > > > >  	KEY(15, 0, KEY_ESC),
> > > > >  	KEY(15, 1, KEY_GRAVE),
> > > > > @@ -178,6 +203,7 @@ static const u32 tegra_kbc_default_keymap[] = {
> > > > >  	KEY(15, 5, KEY_F2),
> > > > >  	KEY(15, 6, KEY_CAPSLOCK),
> > > > >  	KEY(15, 7, KEY_F6),
> > > > > +	KEY(15, 12, KEY_QUESTION),
> > > >
> > > > Not KEY_SLASH or similar?
> > > >
> > > Actually in this keyboard layout that key indeed maps to KEY_QUESTION and not
> > KEY_SLASH.
> > > Is that unexpected.
> > >
> >
> > So it is a dedicated key for a question mark? KEY_QUESTION is not really
> > that although we could re-purpose it (the USB keyboard that is currently
> > using this keycode most likely wants KEY_HELP or similar).
> >
> > Is there a picture of physical keypad somewhere?
> >
> > --
> > Dmitry
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

Re: [PATCH v1] input: tegra-kbc: Add Function keymap.

[Dmitry Torokhov]

On Tue, Feb 15, 2011 at 11:49:12AM -0800, Rakesh Iyer wrote:
> Just wanted to add  -> some of the keys on the extreme right are not present in our keyboard (Euro and Dollar) and some others such as PgUp, PgDown are laid out differently.
> 

OK, sp what is the intended function of that '?' key? Should it produce
question mark or is it a hotkey for invoking help function?

Thanks.

-- 
Dmitry

RE: [PATCH v1] input: tegra-kbc: Add Function keymap.

[Rakesh Iyer]

We do not have a special definition for that key in our system, and going by the original intention it seems it's a help function for the hotkeys.

As far as our system is concerned we do not need the key to do that. Maybe I can avoid mapping that key. Does that seem reasonable?

Thank and Regards
Rakesh

> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> Sent: Tuesday, February 15, 2011 12:01 PM
> To: Rakesh Iyer
> Cc: 'linux-input@vger.kernel.org'; 'olofj@chromium.org'; Andrew Chew
> Subject: Re: [PATCH v1] input: tegra-kbc: Add Function keymap.
> 
> On Tue, Feb 15, 2011 at 11:49:12AM -0800, Rakesh Iyer wrote:
> > Just wanted to add  -> some of the keys on the extreme right are not present in our
> keyboard (Euro and Dollar) and some others such as PgUp, PgDown are laid out differently.
> >
> 
> OK, sp what is the intended function of that '?' key? Should it produce
> question mark or is it a hotkey for invoking help function?
> 
> Thanks.
> 
> --
> Dmitry
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

RE: [PATCH v1] input: tegra-kbc: Add Function keymap.

[Rakesh Iyer]

To add, Does the rest of the patch look okay esp sent as Patch v3?

Regards
Rakesh
> -----Original Message-----
> From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On
> Behalf Of Rakesh Iyer
> Sent: Tuesday, February 15, 2011 1:44 PM
> To: 'Dmitry Torokhov'
> Cc: 'linux-input@vger.kernel.org'; 'olofj@chromium.org'; Andrew Chew
> Subject: RE: [PATCH v1] input: tegra-kbc: Add Function keymap.
> 
> We do not have a special definition for that key in our system, and going by the original
> intention it seems it's a help function for the hotkeys.
> 
> As far as our system is concerned we do not need the key to do that. Maybe I can avoid
> mapping that key. Does that seem reasonable?
> 
> Thank and Regards
> Rakesh
> 
> > -----Original Message-----
> > From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> > Sent: Tuesday, February 15, 2011 12:01 PM
> > To: Rakesh Iyer
> > Cc: 'linux-input@vger.kernel.org'; 'olofj@chromium.org'; Andrew Chew
> > Subject: Re: [PATCH v1] input: tegra-kbc: Add Function keymap.
> >
> > On Tue, Feb 15, 2011 at 11:49:12AM -0800, Rakesh Iyer wrote:
> > > Just wanted to add  -> some of the keys on the extreme right are not present in our
> > keyboard (Euro and Dollar) and some others such as PgUp, PgDown are laid out
> differently.
> > >
> >
> > OK, sp what is the intended function of that '?' key? Should it produce
> > question mark or is it a hotkey for invoking help function?
> >
> > Thanks.
> >
> > --
> > Dmitry
> -----------------------------------------------------------------------------------
> This email message is for the sole use of the intended recipient(s) and may contain
> confidential information.  Any unauthorized review, use, disclosure or distribution
> is prohibited.  If you are not the intended recipient, please contact the sender by
> reply email and destroy all copies of the original message.
> -----------------------------------------------------------------------------------
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1] input: tegra-kbc: Add Function keymap.

[Dmitry Torokhov]

On Tue, Feb 15, 2011 at 01:43:45PM -0800, Rakesh Iyer wrote:
> We do not have a special definition for that key in our system, and going by the original intention it seems it's a help function for the hotkeys.
> 
> As far as our system is concerned we do not need the key to do that. Maybe I can avoid mapping that key. Does that seem reasonable?
> 

Let's just map it to:

#define KEY_HELP                138     /* AL Integrated Help Center */

No need to resend if you agree, I'll simply edit locally.

Thanks.

-- 
Dmitry

RE: [PATCH v1] input: tegra-kbc: Add Function keymap.

[Rakesh Iyer]

Yeah that's perfect.

Regards
Rakesh

> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> Sent: Tuesday, February 15, 2011 1:54 PM
> To: Rakesh Iyer
> Cc: 'linux-input@vger.kernel.org'; 'olofj@chromium.org'; Andrew Chew
> Subject: Re: [PATCH v1] input: tegra-kbc: Add Function keymap.
> 
> On Tue, Feb 15, 2011 at 01:43:45PM -0800, Rakesh Iyer wrote:
> > We do not have a special definition for that key in our system, and going by the original
> intention it seems it's a help function for the hotkeys.
> >
> > As far as our system is concerned we do not need the key to do that. Maybe I can avoid
> mapping that key. Does that seem reasonable?
> >
> 
> Let's just map it to:
> 
> #define KEY_HELP                138     /* AL Integrated Help Center */
> 
> No need to resend if you agree, I'll simply edit locally.
> 
> Thanks.
> 
> --
> Dmitry
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------