From: Randy Dunlap <randy.dunlap@oracle.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dustan Bower <dustan.bower@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Chou <thomas@wytron.com.tw>
Subject: Re: [PATCH] Input: serio: Compile error fix (altera_ps2.c)
Date: Sat, 19 Feb 2011 20:47:50 -0800 [thread overview]
Message-ID: <20110219204750.88014cd8.randy.dunlap@oracle.com> (raw)
In-Reply-To: <AANLkTinaVspNwHZFMUnbp=8F+K-=PRw95a1es+zyeCA+@mail.gmail.com>
On Sat, 19 Feb 2011 20:04:49 -0700 Grant Likely wrote:
> On Sat, Feb 19, 2011 at 2:45 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Sat, Feb 19, 2011 at 03:04:19PM -0500, Dustan Bower wrote:
> >> Fixed compile error, today's linux-next tree:
> >>
> >> CC [M] drivers/input/serio/altera_ps2.o
> >> drivers/input/serio/altera_ps2.c:182:1: error: expected ‘,’ or ‘;’ before ‘extern’
> >> make[1]: *** [drivers/input/serio/altera_ps2.o] Error 1
> >> make: *** [_module_drivers/input/serio] Error 2
> >>
> >> Signed-off-by: Dustan Bower <dustan.bower@gmail.com>
> >
> > Thanks Dustan.
> >
> > Grant, maybe you could amend the original patch so that we do not
> > introduce bisection failure point?
>
> done, thanks.
Hi Grant,
Did you also fix drivers/spi/spi_oc_tiny.c and
drivers/spi/spi_altera.c ? I hit those build errors when
CONFIG_OF=y. Could there be others?
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-02-20 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 20:04 [PATCH] Input: serio: Compile error fix (altera_ps2.c) Dustan Bower
2011-02-19 21:45 ` Dmitry Torokhov
2011-02-20 3:04 ` Grant Likely
2011-02-20 4:47 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110219204750.88014cd8.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dustan.bower@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@wytron.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).