From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dustan Bower <dustan.bower@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Chou <thomas@wytron.com.tw>
Subject: Re: [PATCH] Input: serio: Compile error fix (altera_ps2.c)
Date: Sat, 19 Feb 2011 13:45:49 -0800 [thread overview]
Message-ID: <20110219214549.GA4933@core.coreip.homeip.net> (raw)
In-Reply-To: <1298145859-10892-1-git-send-email-dustan.bower@gmail.com>
On Sat, Feb 19, 2011 at 03:04:19PM -0500, Dustan Bower wrote:
> Fixed compile error, today's linux-next tree:
>
> CC [M] drivers/input/serio/altera_ps2.o
> drivers/input/serio/altera_ps2.c:182:1: error: expected ‘,’ or ‘;’ before ‘extern’
> make[1]: *** [drivers/input/serio/altera_ps2.o] Error 1
> make: *** [_module_drivers/input/serio] Error 2
>
> Signed-off-by: Dustan Bower <dustan.bower@gmail.com>
Thanks Dustan.
Grant, maybe you could amend the original patch so that we do not
introduce bisection failure point?
> ---
> drivers/input/serio/altera_ps2.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/serio/altera_ps2.c b/drivers/input/serio/altera_ps2.c
> index 3fee88b..d363dc4 100644
> --- a/drivers/input/serio/altera_ps2.c
> +++ b/drivers/input/serio/altera_ps2.c
> @@ -178,7 +178,7 @@ static int __devexit altera_ps2_remove(struct platform_device *pdev)
> static const struct of_device_id altera_ps2_match[] = {
> { .compatible = "ALTR,ps2-1.0", },
> {},
> -}
> +};
> MODULE_DEVICE_TABLE(of, altera_ps2_match);
> #else /* CONFIG_OF */
> #define altera_ps2_match NULL
> --
> 1.7.4.1
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-19 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 20:04 [PATCH] Input: serio: Compile error fix (altera_ps2.c) Dustan Bower
2011-02-19 21:45 ` Dmitry Torokhov [this message]
2011-02-20 3:04 ` Grant Likely
2011-02-20 4:47 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110219214549.GA4933@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dustan.bower@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@wytron.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).