linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4 v3] input - wacom : USB Tablet PC support
@ 2011-03-02  0:16 Ping Cheng
  2011-03-05  8:57 ` Henrik Rydberg
  0 siblings, 1 reply; 2+ messages in thread
From: Ping Cheng @ 2011-03-02  0:16 UTC (permalink / raw)
  To: linux-input; +Cc: rydberg, Ping Cheng

Mainly to change the 1FGT devices to the existing touchscreen format and
the 2FGT devices to MT format.

Patches 3 and 4 are at v3. They are updated with Henrik's review comments.
Patches 1 and 2 are the original ones. To make it easy to review the whole
set, all four are resent together.

Ping Cheng (4):
  input : wacom - Remove 2FGT Tablet PC events in TAP format
  input - wacom : process pen data in its own routine
  input - wacom : support one finger touch the touchscreen way
  input - wacom: Support 2FGT in MT format

 drivers/input/tablet/wacom_sys.c |   12 +-
 drivers/input/tablet/wacom_wac.c |  246 +++++++++++++++-----------------------
 drivers/input/tablet/wacom_wac.h |    6 +-
 3 files changed, 103 insertions(+), 161 deletions(-)

-- 
1.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 0/4 v3] input - wacom : USB Tablet PC support
  2011-03-02  0:16 [PATCH 0/4 v3] input - wacom : USB Tablet PC support Ping Cheng
@ 2011-03-05  8:57 ` Henrik Rydberg
  0 siblings, 0 replies; 2+ messages in thread
From: Henrik Rydberg @ 2011-03-05  8:57 UTC (permalink / raw)
  To: Ping Cheng; +Cc: linux-input

Hi Ping,

On Tue, Mar 01, 2011 at 04:16:01PM -0800, Ping Cheng wrote:
> Mainly to change the 1FGT devices to the existing touchscreen format and
> the 2FGT devices to MT format.
> 
> Patches 3 and 4 are at v3. They are updated with Henrik's review comments.
> Patches 1 and 2 are the original ones. To make it easy to review the whole
> set, all four are resent together.
> 
> Ping Cheng (4):
>   input : wacom - Remove 2FGT Tablet PC events in TAP format
>   input - wacom : process pen data in its own routine
>   input - wacom : support one finger touch the touchscreen way
>   input - wacom: Support 2FGT in MT format
> 
>  drivers/input/tablet/wacom_sys.c |   12 +-
>  drivers/input/tablet/wacom_wac.c |  246 +++++++++++++++-----------------------
>  drivers/input/tablet/wacom_wac.h |    6 +-
>  3 files changed, 103 insertions(+), 161 deletions(-)

I believe we are almost there now, thanks for making the change.  With
the nitpicks of the third patch corrected,

Reviewed-by: Henrik Rydberg <rydberg@euromail.se>

Thank you.
Henrik

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-05  8:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-02  0:16 [PATCH 0/4 v3] input - wacom : USB Tablet PC support Ping Cheng
2011-03-05  8:57 ` Henrik Rydberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).