linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	Stephane Chatty <chatty@lii-enac.fr>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] hid-multitouch: Auto detection of maxcontacts
Date: Wed, 9 Mar 2011 09:42:22 +0100	[thread overview]
Message-ID: <20110309084222.GA3569@polaris.bitmath.org> (raw)
In-Reply-To: <1299601979-4871-2-git-send-email-benjamin.tissoires@enac.fr>

Hi Benjamin,

> This patch enables support of autodetection of maxcontacts.
> We can still manually provide maxcontact in case the device
> lies on it.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>

It seems quite alright to let the classes contain the expected number
of contacts, so I do not really see the reason for that part of the
patch. How about keeping the maxcontacts in the class, and then do
max(hid-provided-maxcontacts, default-maxcontacts)?

Thanks,
Henrik

  reply	other threads:[~2011-03-09  8:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 16:32 [PATCH 0/4] Migrations to hid-multitouch Benjamin Tissoires
2011-03-08 16:32 ` [PATCH 1/4] hid-multitouch: Auto detection of maxcontacts Benjamin Tissoires
2011-03-09  8:42   ` Henrik Rydberg [this message]
2011-03-09  9:03     ` Benjamin Tissoires
2011-03-09  9:38       ` Henrik Rydberg
2011-03-09 10:14         ` Benjamin Tissoires
2011-03-09 11:12           ` Henrik Rydberg
2011-03-09 11:22   ` Henrik Rydberg
2011-03-09 12:35     ` Benjamin Tissoires
2011-03-09 13:16       ` Henrik Rydberg
2011-03-08 16:32 ` [PATCH 2/4] hid-multitouch: migrate support for Stantum panels to the unified driver Benjamin Tissoires
2011-03-08 16:32 ` [PATCH 3/4] hid-multitouch: migrate 3M PCT touch screens " Benjamin Tissoires
2011-03-09  8:46   ` Henrik Rydberg
2011-03-09  9:13     ` Benjamin Tissoires
2011-03-09  9:47       ` Henrik Rydberg
2011-03-09 10:17         ` Benjamin Tissoires
2011-03-08 16:32 ` [PATCH 4/4] hid-multitouch: migrate Cando dual touch panels " Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110309084222.GA3569@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=benjamin.tissoires@enac.fr \
    --cc=chatty@lii-enac.fr \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).