From: Peter Hutterer <peter.hutterer@who-t.net>
To: Rafi Rubin <rafi@seas.upenn.edu>
Cc: jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, micki@n-trig.com,
rydberg@euromail.se, chatty@enac.fr
Subject: Re: [PATCH 1/2] hid: ntrig NO_INIT_REPORTS
Date: Fri, 11 Mar 2011 11:42:20 +1000 [thread overview]
Message-ID: <20110311014220.GC8970@barra.bne.redhat.com> (raw)
In-Reply-To: <1299731632-9814-1-git-send-email-rafi@seas.upenn.edu>
On Wed, Mar 09, 2011 at 11:33:51PM -0500, Rafi Rubin wrote:
> Probing reports does bad things with some ntrig firmwares, better to
> just leave them alone.
>
> Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
>
> ---
>
> This resolves an annoying delay on initialization and reduces the
> chance of the device coming up in an odd state or crashing.
never saw those delays but this patch doesn't make anything worse for me.
Tested-by: Peter Hutterer <peter.hutterer@who-t.net>
Cheers,
Peter
> ---
> drivers/hid/hid-ntrig.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
> index b1e9cca..850ba14 100644
> --- a/drivers/hid/hid-ntrig.c
> +++ b/drivers/hid/hid-ntrig.c
> @@ -837,7 +837,8 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id)
> struct hid_report *report;
>
> if (id->driver_data)
> - hdev->quirks |= HID_QUIRK_MULTI_INPUT;
> + hdev->quirks |= HID_QUIRK_MULTI_INPUT
> + | HID_QUIRK_NO_INIT_REPORTS;
>
> nd = kmalloc(sizeof(struct ntrig_data), GFP_KERNEL);
> if (!nd) {
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2011-03-11 1:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 4:33 [PATCH 1/2] hid: ntrig NO_INIT_REPORTS Rafi Rubin
2011-03-10 4:33 ` [PATCH 2/2] hid-ntrig: init settle and mode check Rafi Rubin
2011-03-11 1:52 ` Peter Hutterer
2011-03-14 12:10 ` Jiri Kosina
2011-03-10 10:38 ` [PATCH 1/2] hid: ntrig NO_INIT_REPORTS Jiri Kosina
2011-03-11 1:42 ` Peter Hutterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110311014220.GC8970@barra.bne.redhat.com \
--to=peter.hutterer@who-t.net \
--cc=chatty@enac.fr \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micki@n-trig.com \
--cc=rafi@seas.upenn.edu \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).