From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: "Richard Nauber" <richard.nauber@googlemail.com>,
linux-input <linux-input@vger.kernel.org>,
"Jiri Kosina" <jkosina@suse.cz>,
"Stéphane Chatty" <chatty@enac.fr>
Subject: Re: [PATCH v3] [input-hid] Add hid-egalax driver to the unified hid-multitouch framework.
Date: Fri, 11 Mar 2011 12:31:57 +0100 [thread overview]
Message-ID: <20110311113157.GA3342@polaris.bitmath.org> (raw)
In-Reply-To: <AANLkTimQWT9BtLHVL8HgaiS8tabrtUYGK-Z3qjH73QvH@mail.gmail.com>
On Fri, Mar 11, 2011 at 10:52:55AM +0100, Benjamin Tissoires wrote:
> Hi Richard,
>
> On Fri, Mar 11, 2011 at 10:23, Richard Nauber
> <richard.nauber@googlemail.com> wrote:
> >>On Fri, Mar 11, 2011 at 7:53 AM, Benjamin Tissoires
> >><benjamin.tissoires@gmail.com> wrote:
> >> Hi Richard,
> >>
> >> I'm really sorry, but it's a NACK for me:
> >> what ever Henrik said, I do not want to have numerical constants
> >> throughout the code. It would be the open door to many others. The
> >> reason we have "mt_class" is to regroup each per-device parameters in
> >> it. So there is no need to introduce those constants everywhere.
> >
> > Hm, so should I make a patch that applies on top of Henriks "Send
> > events per slot if CONTACTCOUNT is missing" and uses the generic XY
> > fixup of my v3 patch?
> >
>
> I would say so. Please just change the name of the field .axis by a better name.
I disagree with this approach. The code in question is per device bug,
not per device. The next firmware bug might be that the axis are
shifted, or that the value is given with wrong byte order, we just
don't know. Until we know what the next bug has in common with the old
ones, let's be simple.
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-11 11:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 13:25 [PATCH] [input-hid] Add hid-egalax driver to the unified hid-multitouch framework Richard Nauber
2011-03-07 10:07 ` Benjamin Tissoires
2011-03-08 6:08 ` [PATCH v2] " Richard Nauber
2011-03-08 8:04 ` Henrik Rydberg
2011-03-08 8:55 ` Benjamin Tissoires
2011-03-08 9:14 ` Henrik Rydberg
2011-03-08 9:23 ` Benjamin Tissoires
2011-03-08 9:46 ` Henrik Rydberg
2011-03-08 23:38 ` [PATCH v3] " Richard Nauber
2011-03-09 8:24 ` Henrik Rydberg
2011-03-09 8:54 ` Benjamin Tissoires
2011-03-09 9:23 ` Henrik Rydberg
2011-03-09 10:06 ` Benjamin Tissoires
2011-03-09 11:40 ` Henrik Rydberg
2011-03-11 6:02 ` Richard Nauber
2011-03-11 6:53 ` Benjamin Tissoires
2011-03-11 9:23 ` Richard Nauber
2011-03-11 9:52 ` Benjamin Tissoires
2011-03-11 11:31 ` Henrik Rydberg [this message]
2011-03-14 12:06 ` Jiri Kosina
2011-03-08 13:12 ` [PATCH] " Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110311113157.GA3342@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=richard.nauber@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).