From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: srk@ti.com, linux-sh@vger.kernel.org,
chinyeow.sim.xt@renesas.com, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: tca6416-keypad: Suspend/Resume wakeup support
Date: Tue, 15 Mar 2011 22:51:02 -0700 [thread overview]
Message-ID: <20110316055102.GC14604@core.coreip.homeip.net> (raw)
In-Reply-To: <AANLkTimj3W_SdnHDs1tpWxDZEN8S17zHMDVAU+Zr=fG9@mail.gmail.com>
On Wed, Mar 16, 2011 at 02:45:11PM +0900, Magnus Damm wrote:
> On Wed, Mar 16, 2011 at 2:32 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Wed, Mar 16, 2011 at 02:10:30PM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> Extend the tca6416 driver to use enable_irq_wake()
> >> and disable_irq_wake() in the suspend/resume hooks.
> >>
> >> This makes it possible to wake up from suspend-to-ram
> >> using a tca6416 key on the sh7372 mackerel board.
> >>
> >
> > Hi Magnus,
> >
> > Looks good, but why don't we guard PM code with CONFIG_PM_SLEEP, like
> > below? I also believe we should use bus-specific helpers to access
> > private driver data since it does not have to stay alias for the
> > core data pointer.
>
> Hi Dmitry,
>
> Thank you for the updated patch, your version looks much better than
> mine. I tested your version on my Mackerel board a few minutes ago and
> it is still working as expected. Unless there are any objections,
> please merge your version of the patch.
>
Excellent, I'll queue it up.
Thank you for testing the updated patch.
--
Dmitry
prev parent reply other threads:[~2011-03-16 5:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 5:10 [PATCH] Input: tca6416-keypad: Suspend/Resume wakeup support Magnus Damm
2011-03-16 5:32 ` Dmitry Torokhov
2011-03-16 5:45 ` Magnus Damm
2011-03-16 5:51 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316055102.GC14604@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chinyeow.sim.xt@renesas.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).