From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] Input: wm831x-ts - Fix races with IRQ management
Date: Fri, 18 Mar 2011 11:20:44 +0000 [thread overview]
Message-ID: <20110318112043.GA27129@sirena.org.uk> (raw)
In-Reply-To: <1300142701-22260-2-git-send-email-broonie@opensource.wolfsonmicro.com>
On Mon, Mar 14, 2011 at 10:45:01PM +0000, Mark Brown wrote:
> This revision reworks the close() implementation, hopefully more
> robustly, which should address the main thrust of your comments
> previously. As I said in my previous e-mail the restrictions on
> enable_irq() seem reasonable to me, the thing that's nasty here is that
> we need to enable and disable the IRQs at all.
It'd be good to get something for this into 2.6.39. At the very least
this version of the patch avoids issues while the device is open and
keeps any issues in close() which is an improvement. If this approach
isn't going to be OK please let me know so I can look into alternatives.
next prev parent reply other threads:[~2011-03-18 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 22:45 [PATCH 1/2] Input: wm831x-ts - Ensure the controller is in a known state on open Mark Brown
2011-03-14 22:45 ` [PATCH 2/2] Input: wm831x-ts - Fix races with IRQ management Mark Brown
2011-03-18 11:20 ` Mark Brown [this message]
2011-03-25 7:30 ` Dmitry Torokhov
2011-03-25 10:49 ` Mark Brown
2011-03-16 6:31 ` [PATCH 1/2] Input: wm831x-ts - Ensure the controller is in a known state on open Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318112043.GA27129@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).