linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Paul Mundt <lethal@linux-sh.org>,
	dmitry.torokhov@gmail.com, srk@ti.com, khilman@ti.com,
	chinyeow.sim.xt@renesas.com, linux-sh@vger.kernel.org,
	tony@atomide.com, nsekhar@ti.com, linux-i2c@vger.kernel.org,
	linux-input@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Input: tca6416-keypad: Change to module_init()
Date: Tue, 22 Mar 2011 16:59:07 +0000	[thread overview]
Message-ID: <20110322165907.GG22583@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <AANLkTiniBVWhSiNZMRYbO857D_Vj03KxH4qYqkVo-11J@mail.gmail.com>

On Wed, Mar 23, 2011 at 01:51:02AM +0900, Magnus Damm wrote:

> I'm not sure if this is i2c specific though - in general you probably
> need to register the parent bus driver first.

This was my original question - I'm not aware of any reason why you
should need to register the driver for the specific bus first, it seems
odd.

> I've seen some SH-Mobile designs with PMICs, and they all use a
> dedicated i2c bus.

It's the most common bus for PMICs but some use SPI for performance
reasons, especially if they integrate other mixed signal functionality
such as touchscreen controllers that might be high volume.

> > In general embedded platforms register I2C early as things like PMICs
> > typically hang off them.  Grant was trying to push people to use
> > deferred registration for this stuff but it didn't happen yet and I'd
> > personally be more comfortable with more infastructure supporting that.

> The dependency tracking is a bit primitive with only initcalls. I
> wouldn't mind something like this:

That's not a general solution as it doesn't cover things like cross
dependencies between devices on the same bus type.  You really want to
be able to say "I depend on this set of other devices" somehow, the
proposal from Grant that I'm talking about was to only register devices
once their dependencies had appeared which solves the issue but is a bit
manual for the board files.

  reply	other threads:[~2011-03-22 16:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 14:26 [PATCH] Input: tca6416-keypad: Change to module_init() Magnus Damm
2011-03-22 14:28 ` Mark Brown
2011-03-22 14:33   ` Paul Mundt
2011-03-22 15:22     ` Magnus Damm
2011-03-22 15:32       ` Paul Mundt
2011-03-22 15:43         ` Magnus Damm
     [not found]           ` <AANLkTimyxdcJ-eEke9x7X1zdiJNbFtncfv0=NzKjtAme-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-22 15:57             ` Paul Mundt
2011-03-22 16:20               ` Magnus Damm
2011-03-22 16:31                 ` Mark Brown
     [not found]                   ` <20110322163144.GC2202-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2011-03-22 16:51                     ` Magnus Damm
2011-03-22 16:59                       ` Mark Brown [this message]
     [not found]                         ` <20110322165907.GG22583-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-03-23 16:04                           ` Magnus Damm
2011-03-23 16:20                             ` Mark Brown
     [not found]                               ` <20110323162021.GA26594-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-03-24  3:38                                 ` Magnus Damm
2011-03-24  7:57                                   ` Dmitry Torokhov
2011-03-29  7:11                             ` Magnus Damm
2011-03-22 15:16   ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110322165907.GG22583@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=chinyeow.sim.xt@renesas.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=khilman@ti.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=nsekhar@ti.com \
    --cc=srk@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).