From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: tca6416-keypad: Change to module_init() Date: Thu, 24 Mar 2011 00:57:27 -0700 Message-ID: <20110324075727.GB8990@core.coreip.homeip.net> References: <20110322153226.GC30303@linux-sh.org> <20110322155730.GD30303@linux-sh.org> <20110322163144.GC2202@sirena.org.uk> <20110322165907.GG22583@opensource.wolfsonmicro.com> <20110323162021.GA26594@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Magnus Damm Cc: Mark Brown , Paul Mundt , srk@ti.com, khilman@ti.com, chinyeow.sim.xt@renesas.com, linux-sh@vger.kernel.org, tony@atomide.com, nsekhar@ti.com, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-input@vger.kernel.org On Thu, Mar 24, 2011 at 12:38:21PM +0900, Magnus Damm wrote: > On Thu, Mar 24, 2011 at 1:20 AM, Mark Brown > wrote: > > On Thu, Mar 24, 2011 at 01:04:31AM +0900, Magnus Damm wrote: > > > >> Sounds nice. Hopefully that will allow us to use module_init() in > >> drivers instead of other initcall levels depending on bus type. > > > > None of this is anything to do with the bus type - it's to do with = the > > function of the devices within the system. =A0Things that are requi= red for > > early init of the kernel get bumped up the list. >=20 > Hm, sorry for being unclear - I should have used the words "other > initcall levels depending on the init order of the parent hardware > bus". I'm referring to the state of things now without any patches > from Grant. >=20 > I understand that early init code often are using different initcall > levels to make sure they are getting initialized before other code. > Initcalls can also be used to work around link order issues. >=20 > I can't however see the reason why a keypad driver needs to be > initialized early on. I may be wrong, but I thought user space was th= e > only consumer of input devices? >=20 SysRq is kind of a consumer, so there sometimes a desire to get keyboar= d working as soon as possible. But even SysRq is initialized ad module_in= it level, so I tend to agree that tca should simply use module_init. --=20 Dmitry