From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] Input: wm831x-ts - Fix races with IRQ management
Date: Fri, 25 Mar 2011 10:49:46 +0000 [thread overview]
Message-ID: <20110325104945.GA31415@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110325073032.GB2590@core.coreip.homeip.net>
On Fri, Mar 25, 2011 at 12:30:32AM -0700, Dmitry Torokhov wrote:
> I am just not comfortable with a touchcsreen requiring essentially 2
> threads to operate (2 IRQ threads, 2 works). I was thinking about
> converting to a thread with a state machine and 2 non-threaded IRQs
> disabling themselves and waking the thread up. Do you think something
> like that would work?
You can't use non-threaded IRQs as the chip is accessed over I2C or SPI
so when using the built in interrupts you're in thread context before
you've decoded the IRQ. Given the need to ack the IRQ to stop it trying
to do something it doesn't seem worth trying to move the chip
interaction out of the IRQ handlers there - it'd just be performance
pain and you'd still need to worry about which IRQs are enabled at any
given moment since you'd need to disable the IRQs if you wanted to defer
handling them.
Combining the two work items to do the IRQ enable handovers should be
doable, though.
next prev parent reply other threads:[~2011-03-25 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 22:45 [PATCH 1/2] Input: wm831x-ts - Ensure the controller is in a known state on open Mark Brown
2011-03-14 22:45 ` [PATCH 2/2] Input: wm831x-ts - Fix races with IRQ management Mark Brown
2011-03-18 11:20 ` Mark Brown
2011-03-25 7:30 ` Dmitry Torokhov
2011-03-25 10:49 ` Mark Brown [this message]
2011-03-16 6:31 ` [PATCH 1/2] Input: wm831x-ts - Ensure the controller is in a known state on open Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110325104945.GA31415@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).