From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ping Cheng <pinglinux@gmail.com>
Cc: Chris Bagwell <chris@cnpbagwell.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] input : wacom - report resolution for pen devices
Date: Sun, 27 Mar 2011 12:07:51 -0700 [thread overview]
Message-ID: <20110327190751.GA31692@core.coreip.homeip.net> (raw)
In-Reply-To: <AANLkTinV4KzSkF9eRY8urZ7sM9dxz2pPaQs+vtX52GAF@mail.gmail.com>
On Sun, Mar 27, 2011 at 11:59:29AM -0700, Ping Cheng wrote:
> On Sun, Mar 27, 2011 at 7:32 AM, Chris Bagwell <chris@cnpbagwell.com> wrote:
>
> > On Fri, Mar 25, 2011 at 7:29 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> > > Touch resolution is reported to the userland by retrieving
> > > the value from the HID descriptor. But pen resolution is not
> > > since it can not be retrieved. The current Wacom X driver
> > > has a resolution table. To centralize the source of these
> > > values, the resolution entries are added in the wacom_features
> > > struct for x and y coordinates respectively. The values are
> > > then reported to the userland.
> > >
> > > Signed-off-by: Ping Cheng <pingc@wacom.com>
> >
> > I'm glad you gave up on me saying I'd eventually make this change. :-)
> >
> > My hold up was I was debating to myself if it should have separate X/Y
> > resolutions or just a single field. Its unlikely Wacom will ship
> > unmatched X/Y's. For what its worth, a version of this change in my
> > local tree also kept separate X/Y's.
> >
>
> I thought about that when I worked on the patch too. I decided to have
> separate entries for x and y since it adds flexibility for future devices.
>
Applied both, altough without Chris's reviwed-by tags as I already pushed
by public branch out...
--
Dmitry
prev parent reply other threads:[~2011-03-27 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 0:29 [PATCH 2/2] input : wacom - report resolution for pen devices Ping Cheng
2011-03-27 14:32 ` Chris Bagwell
[not found] ` <AANLkTinV4KzSkF9eRY8urZ7sM9dxz2pPaQs+vtX52GAF@mail.gmail.com>
2011-03-27 19:07 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110327190751.GA31692@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chris@cnpbagwell.com \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).