From: Wolfram Sang <w.sang@pengutronix.de>
To: Christopher Heiny <cheiny@synaptics.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jean Delvare <khali@linux-fr.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Allie Xiong <axiong@synaptics.com>,
William Manson <wmanson@synaptics.com>,
Joerie de Gram <j.de.gram@gmail.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>
Subject: Re: [PATCH 1/3] input/touchscreen: Synaptics RMI4 Touchscreen Driver
Date: Wed, 30 Mar 2011 10:02:23 +0200 [thread overview]
Message-ID: <20110330080223.GB2232@pengutronix.de> (raw)
In-Reply-To: <1301446249-13646-2-git-send-email-cheiny@synaptics.com>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
Hi,
> + retval = rmi_register_sensor(&instancedata->rmiphysdrvr, platformdata->perfunctiondata);
> + if (retval) {
> + dev_err(&client->dev, "%s: Failed to Register %s sensor drivers\n",
> + __func__, instancedata->rmiphysdrvr.name);
> + i2c_set_clientdata(client, NULL);
I originally just wanted to say that this line can be removed. Then I
remembered that I already sent a patch for a similar driver in staging
(dc7b202a4ee6cb686e2bbef80c84443f43ec91bd). The staging driver looks in
a better shape to me. Do you know about it?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-03-30 8:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 0:50 [PATCH 0/3] input/touchscreen: Synaptics RMI4 Touchscreen Driver Christopher Heiny
2011-03-30 0:50 ` [PATCH 1/3] " Christopher Heiny
2011-03-30 8:02 ` Wolfram Sang [this message]
2011-03-30 18:36 ` Christopher Heiny
2011-03-30 19:44 ` Wolfram Sang
2011-03-30 21:08 ` Christopher Heiny
2011-03-30 11:46 ` Joerie de Gram
2011-03-30 14:00 ` Christopher Heiny
2011-03-30 0:50 ` [PATCH 2/3] " Christopher Heiny
2011-03-30 0:50 ` [PATCH 3/3] " Christopher Heiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330080223.GB2232@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=axiong@synaptics.com \
--cc=cheiny@synaptics.com \
--cc=dmitry.torokhov@gmail.com \
--cc=j.de.gram@gmail.com \
--cc=khali@linux-fr.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.gaddipati@stericsson.com \
--cc=wmanson@synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).