* [PATCH] Input: rpckbd - fix a leak of the IRQ during init failure
@ 2011-04-03 1:41 Axel Lin
2011-04-03 4:20 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-04-03 1:41 UTC (permalink / raw)
To: linux-kernel; +Cc: Dmitry Torokhov, linux-input
In rpckbd_open prror path, free_irq() was using NULL rather than the
driver data as the data pointer so free_irq() wouldn't have matched.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/input/serio/rpckbd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/serio/rpckbd.c b/drivers/input/serio/rpckbd.c
index 9da6fbc..7ec3c97 100644
--- a/drivers/input/serio/rpckbd.c
+++ b/drivers/input/serio/rpckbd.c
@@ -90,7 +90,7 @@ static int rpckbd_open(struct serio *port)
if (request_irq(IRQ_KEYBOARDTX, rpckbd_tx, 0, "rpckbd", port) != 0) {
printk(KERN_ERR "rpckbd.c: Could not allocate keyboard transmit IRQ\n");
- free_irq(IRQ_KEYBOARDRX, NULL);
+ free_irq(IRQ_KEYBOARDRX, port);
return -EBUSY;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: rpckbd - fix a leak of the IRQ during init failure
2011-04-03 1:41 [PATCH] Input: rpckbd - fix a leak of the IRQ during init failure Axel Lin
@ 2011-04-03 4:20 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2011-04-03 4:20 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, linux-input
On Sun, Apr 03, 2011 at 09:41:06AM +0800, Axel Lin wrote:
> In rpckbd_open prror path, free_irq() was using NULL rather than the
> driver data as the data pointer so free_irq() wouldn't have matched.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks Axel.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-03 4:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-03 1:41 [PATCH] Input: rpckbd - fix a leak of the IRQ during init failure Axel Lin
2011-04-03 4:20 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).