From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Jiejing Zhang <kzjeef@gmail.com>,
linux-input@vger.kernel.org,
Zhang Jiejing <jiejing.zhang@freescale.com>
Subject: Re: [PATCH] input: add mpr121 capacitive touchkey driver
Date: Mon, 11 Apr 2011 23:01:53 -0700 [thread overview]
Message-ID: <20110412060153.GB1854@core.coreip.homeip.net> (raw)
In-Reply-To: <20110411232010.GC3579@lovely.krouter>
On Tue, Apr 12, 2011 at 01:20:11AM +0200, Christoph Fritz wrote:
> On Tue, Apr 12, 2011 at 01:02:17AM +0800, Jiejing Zhang wrote:
> > +
> > +static SIMPLE_DEV_PM_OPS(mpr121_touchkey_pm_ops, mpr_suspend, mpr_resume);
> > +
> > +static struct i2c_driver mpr_touchkey_driver = {
> > + .driver = {
> > + .name = "mpr121",
> > + .owner = THIS_MODULE,
> > + .pm = &mpr121_touchkey_pm_ops,
>
> I would add a ifdef CONFIG_PM_SLEEP
>
No, since we could try supporting CONFIG_PM_RUNTIME for example (not
necessarily in this driver, but in general case). dev_pm_ops structire
is defined always but it contents change de3pending on CONFIG_PM_SLEEP.
CONFIG_PM_RUNTILE and so forth. At a minium it is an empty structure,
but it woudl still be defined.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-04-12 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 17:02 [PATCH] input: add mpr121 capacitive touchkey driver Jiejing Zhang
2011-04-11 23:20 ` Christoph Fritz
2011-04-12 6:01 ` Dmitry Torokhov [this message]
[not found] ` <BANLkTimsN2ff53i9FYCoatRa+rAjamnMaQ@mail.gmail.com>
2011-04-12 11:41 ` Jiejing.Zhang
2011-04-12 14:29 ` Christoph Fritz
2011-04-13 1:42 ` Jiejing.Zhang
2011-04-12 6:18 ` Dmitry Torokhov
2011-04-13 1:23 ` Jiejing.Zhang
2011-04-13 2:28 ` [PATCH v2] input: keyboard: FSL MPR121 capacitive touch button Zhang Jiejing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412060153.GB1854@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chf.fritz@googlemail.com \
--cc=jiejing.zhang@freescale.com \
--cc=kzjeef@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).