From: "Henrik Rydberg" <rydberg@euromail.se>
To: Sadrul Chowdhury <sadrul@chromium.org>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] input-mt: Allow -1 for tracking id
Date: Fri, 15 Apr 2011 09:00:00 +0200 [thread overview]
Message-ID: <20110415070000.GA7135@polaris.bitmath.org> (raw)
In-Reply-To: <BANLkTimcCh7MbmxtuzTCEFyT28FHZU+ijw@mail.gmail.com>
Hi Sadrul,
On Thu, Apr 14, 2011 at 06:13:17PM -0400, Sadrul Chowdhury wrote:
> In protocol B, the tracking ID can be set to -1. But since the min
> value is set to 0, the clients don't receive a -1 when a contact is
> lifted. The attached patch sets the min to -1 to fix this issue.
All ABS_MT_TRACKING_ID values outside the valid value range denote an
invalid touch. To simplify implementation in userland, where the valid
range may not always be known, the documentation was changed to say
"-1" instead. Apparently the original explanation was unintentionally
dropped with it.
Because the change goes against the semantics of the tracking id, this
patch constitues an interface breakage, with malfunctions in userspace
as a result. Therefore, this patch will not be applied.
Thanks,
Henrik
next prev parent reply other threads:[~2011-04-15 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 22:13 [PATCH] input-mt: Allow -1 for tracking id Sadrul Chowdhury
2011-04-15 7:00 ` Henrik Rydberg [this message]
2011-04-15 13:09 ` Sadrul Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415070000.GA7135@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=linux-input@vger.kernel.org \
--cc=sadrul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).