From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: h3600_ts_input - bugfix for request_irq()/free_irq() parameters
Date: Sun, 1 May 2011 09:50:58 -0700 [thread overview]
Message-ID: <20110501165058.GA23240@core.coreip.homeip.net> (raw)
In-Reply-To: <BANLkTi=BpdfE+VmBZuzaodNiE9JUhARbfg@mail.gmail.com>
On Mon, May 02, 2011 at 12:23:43AM +0800, Axel Lin wrote:
> Hi Dmitry,
>
> 2011/4/29 Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> > On Wed, Apr 13, 2011 at 08:37:11PM +0800, Axel Lin wrote:
> >> The dev field of h3600_dev is a pointer, thus use ts->dev instead of &ts->dev
> >> as the dev_id argument while calling request_irq()/free_irq().
> >
> > dev_id does not need to have specific type, it is just a cookie so as
> > long as it's value is unique we are OK. &ts->dev works as well as
> > ts->dev.
>
> Then you might want to apply below patch:
> http://www.spinics.net/lists/linux-input/msg15042.html
>
> My original intension was to fix the irq driver data mismatch.
>
Ah, I see. Then I'll apply it but with teh above as commit message.
--
Dmitry
prev parent reply other threads:[~2011-05-01 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 12:37 [PATCH] Input: h3600_ts_input - bugfix for request_irq()/free_irq() parameters Axel Lin
2011-04-28 16:26 ` Dmitry Torokhov
2011-05-01 16:23 ` Axel Lin
2011-05-01 16:50 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110501165058.GA23240@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=axel.lin@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).