From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: linux-input@vger.kernel.org, Kwangwoo Lee <kwlee@mtekvision.com>
Subject: Re: [PATCH 2/5] tsc2007: Add max_rt module parameter.
Date: Mon, 16 May 2011 22:58:35 -0700 [thread overview]
Message-ID: <20110517055835.GB20428@core.coreip.homeip.net> (raw)
In-Reply-To: <20110517054620.GB9943@avionic-0098.mockup.avionic-design.de>
On Tue, May 17, 2011 at 07:46:20AM +0200, Thierry Reding wrote:
> * Dmitry Torokhov wrote:
> > Hi Thierry,
> >
> > On Mon, May 16, 2011 at 10:33:00AM +0200, Thierry Reding wrote:
> > > Finger touch events or very quick stylus events on low-quality panels
> > > can cause the tsc2007 to read bogus values. Looking at oscilloscope
> > > snapshots, this seems to be caused by the touch event disappearing
> > > during the measurements. These bogus values result in misclicks, where
> > > the X and Y values deviate from the real position.
> > >
> > > Most of these misclicks can be filtered out by setting a low enough
> > > threshold for the maximum resistance (which is loosely the inverse of
> > > the pressure) allowed to consider a set of values valid. Since this
> > > behaviour is largely dependent on the type and quality of the panel,
> > > this commit introduces the max_rt parameter. The default value is kept
> > > at MAX_12BIT.
> >
> > I expect that the values, once selected, will not be changed for a given
> > panel, so why don't we pass max_rt (and poll_delay and poll_interval) vi
> > platform (board) data instead of being module parameters?
>
> I was using module parameters because it allows the parameters to be tuned at
> runtime. You are correct however in that they don't vary after being selected
> once. I can resend an updated patch series with those parameters added to the
> platform data if you prefer.
Yes, please.
>
> By the way, Kwangwoo's email address no longer seems to be valid. Searching
> the kernel tree, there also seems to be kwangwoo.lee@gmail.com. Do you know
> if it is current?
No, I do not.
--
Dmitry
next prev parent reply other threads:[~2011-05-17 5:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 8:32 [PATCH 1/5] tsc2007: Debounce pressure measurement Thierry Reding
2011-05-16 8:33 ` [PATCH 2/5] tsc2007: Add max_rt module parameter Thierry Reding
2011-05-16 16:53 ` Dmitry Torokhov
2011-05-17 5:46 ` Thierry Reding
2011-05-17 5:58 ` Dmitry Torokhov [this message]
2011-05-17 6:59 ` Thierry Reding
2011-05-17 7:24 ` Dmitry Torokhov
2011-05-16 8:33 ` [PATCH 3/5] tsc2007: Introduce poll_delay parameter Thierry Reding
2011-05-16 8:33 ` [PATCH 4/5] tsc2007: Introduce poll_period parameter Thierry Reding
2011-05-16 8:33 ` [PATCH 5/5] tsc2007: Add X, Y and Z fuzz factors to platform data Thierry Reding
2011-05-17 6:02 ` [PATCH 1/5] tsc2007: Debounce pressure measurement Dmitry Torokhov
2011-05-17 6:27 ` Thierry Reding
2011-05-17 6:32 ` Dmitry Torokhov
2011-05-17 6:45 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110517055835.GB20428@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=kwlee@mtekvision.com \
--cc=linux-input@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).