From: Thierry Reding <thierry.reding@avionic-design.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Kwangwoo Lee <kwangwoo.lee@gmail.com>
Subject: Re: [PATCH 1/5] tsc2007: Debounce pressure measurement.
Date: Tue, 17 May 2011 08:27:16 +0200 [thread overview]
Message-ID: <20110517062715.GA16262@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <20110517060241.GC20428@core.coreip.homeip.net>
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
[Cc'ing Kwangwoo via the alternate email address]
* Dmitry Torokhov wrote:
> On Mon, May 16, 2011 at 10:32:59AM +0200, Thierry Reding wrote:
> > When the controller signals a pen-down event via the platform-specific
> > GPIO, while the sample values indicate an invalid measurement, the
> > measurement needs to be repeated.
> >
>
> Would not we be interrupted again and take another sample then?
Not necessarily. The problem is that if the pendown GPIO reports pendown, it
doesn't necessarily mean that the pressure measurement will be valid. This is
especially true if max_rt is configurable (as introduced by one of the
follow-up patchs).
What happens is that we are interrupted, check the GPIO to see that the pen
is indeed down and then read the values and compute the pressure to see that
it is invalid and we stop sampling. The TSC2007's nPEN_IRQ line never goes
high again after that because the pen is still down (according to the GPIO).
The comment in the old code of the (rt > max_rt) even says "[...] repeat at
least once more the measurement", which the old code actually doesn't.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-05-17 6:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 8:32 [PATCH 1/5] tsc2007: Debounce pressure measurement Thierry Reding
2011-05-16 8:33 ` [PATCH 2/5] tsc2007: Add max_rt module parameter Thierry Reding
2011-05-16 16:53 ` Dmitry Torokhov
2011-05-17 5:46 ` Thierry Reding
2011-05-17 5:58 ` Dmitry Torokhov
2011-05-17 6:59 ` Thierry Reding
2011-05-17 7:24 ` Dmitry Torokhov
2011-05-16 8:33 ` [PATCH 3/5] tsc2007: Introduce poll_delay parameter Thierry Reding
2011-05-16 8:33 ` [PATCH 4/5] tsc2007: Introduce poll_period parameter Thierry Reding
2011-05-16 8:33 ` [PATCH 5/5] tsc2007: Add X, Y and Z fuzz factors to platform data Thierry Reding
2011-05-17 6:02 ` [PATCH 1/5] tsc2007: Debounce pressure measurement Dmitry Torokhov
2011-05-17 6:27 ` Thierry Reding [this message]
2011-05-17 6:32 ` Dmitry Torokhov
2011-05-17 6:45 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110517062715.GA16262@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=dmitry.torokhov@gmail.com \
--cc=kwangwoo.lee@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).