From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Girdwood, Liam" <lrg@ti.com>
Subject: Re: [PATCH 3/8] MFD: twl4030-audio: Rename platform data
Date: Wed, 1 Jun 2011 06:00:34 -0700 [thread overview]
Message-ID: <20110601130034.GE11352@atomide.com> (raw)
In-Reply-To: <201106011554.53090.peter.ujfalusi@ti.com>
* Peter Ujfalusi <peter.ujfalusi@ti.com> [110601 05:50]:
> On Wednesday 01 June 2011 15:07:54 Tony Lindgren wrote:
> >
> > Can you please take a look at creating arch/arm/mach-omap2/i2c-twl.c or
> > something in common-board-devices.c to get rid of the cut and paste
> > duplication in every board-*.c file?
>
> Yes, it would make sense, since most of the board has similar configuration,
> and we have lots of duplicated code around.
>
> > Maybe you could have a generic twl_init function that allows overriding
> > things like keypad with board specific configuration?
>
> We might need also support for overriding other configurations
> (audio/codec/vibra for sure needs that).
Yeah, most of it might be possible to describe with just a flags
like TWL_HAS_VIBRA etc.
> I'll take a look, but I think it is not going to be part of v2 of this series.
We should not do renaming before the clean-up though, it gets
classified as "unnecesary churn".
Tony
next prev parent reply other threads:[~2011-06-01 13:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 11:17 [PATCH 0/8] MFD/ASoC: TWL4030/TWL6040 changes Peter Ujfalusi
2011-06-01 11:17 ` [PATCH 1/8] MFD: twl4030-codec: Rename internals from codec to audio Peter Ujfalusi
2011-06-01 11:17 ` [PATCH 2/8] MFD: twl4030-codec -> twl4030-audio: Rename the driver Peter Ujfalusi
2011-06-01 11:17 ` [PATCH 3/8] MFD: twl4030-audio: Rename platform data Peter Ujfalusi
2011-06-01 12:07 ` Tony Lindgren
2011-06-01 12:54 ` Peter Ujfalusi
2011-06-01 13:00 ` Tony Lindgren [this message]
2011-06-01 13:17 ` Peter Ujfalusi
2011-06-01 13:38 ` Tony Lindgren
2011-06-02 6:15 ` Peter Ujfalusi
2011-06-03 8:08 ` Tony Lindgren
2011-06-03 13:38 ` Peter Ujfalusi
2011-06-06 9:55 ` Tony Lindgren
2011-06-01 11:17 ` [PATCH 4/8] mfd: twl6040: Add initial support Peter Ujfalusi
2011-06-01 13:47 ` T Krishnamoorthy, Balaji
2011-06-03 16:44 ` Peter Ujfalusi
2011-06-01 11:17 ` [PATCH 5/8] ASoC: twl6040: Convert into TWL6040 MFD child Peter Ujfalusi
2011-06-01 11:17 ` [PATCH 6/8] MFD: twl6040: Change platform data for soc codec driver Peter Ujfalusi
2011-06-01 11:17 ` [PATCH 7/8] input: Add initial support for TWL6040 vibrator Peter Ujfalusi
2011-06-01 11:17 ` [PATCH 8/8] OMAP4: SDP4430: Add twl6040 vibrator platform support Peter Ujfalusi
2011-06-02 8:29 ` [PATCH 0/8] MFD/ASoC: TWL4030/TWL6040 changes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601130034.GE11352@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).