From: David Jander <david.jander@protonic.nl>
To: Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] INPUT: gpio_keys.c: Added OF support and enabled use with I2C GPIO expanders
Date: Mon, 6 Jun 2011 11:12:44 +0200 [thread overview]
Message-ID: <20110606111244.406f0cd3@archvile> (raw)
In-Reply-To: <BANLkTinNMeiimJqzFsWSS2zDggZ-o5k=fA@mail.gmail.com>
On Thu, 2 Jun 2011 15:18:29 +0530
Shubhrajyoti Datta <omaplinuxkernel@gmail.com> wrote:
> On Wed, Jun 1, 2011 at 2:37 PM, <y@protonic.xs4all.nl> wrote:
>
> > From: David Jander <david@protonic.nl>
> >
> > You may want to briefly explain the changes.
>
> <Snip>
>
> > +
> > input = input_allocate_device();
> > if (!ddata || !input) {
> > dev_err(dev, "failed to allocate state\n");
> > @@ -465,12 +585,12 @@ static int __devinit gpio_keys_probe(struct
> > platform_device *pdev)
> > ddata->disable = pdata->disable;
> > mutex_init(&ddata->disable_lock);
> >
> > - platform_set_drvdata(pdev, ddata);
> > + dev_set_drvdata(dev, ddata);
> > input_set_drvdata(input, ddata);
> >
> > - input->name = pdev->name;
> > + input->name = "GPIO_keyboard";
> >
> Why this change?
Good question.... somehow it isn't necessary anymore, and it was quite wrong
anyway. Thanks for pointing out, must have slipped over this....
Best regards,
--
David Jander
Protonic Holland.
next parent reply other threads:[~2011-06-06 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6613128190865466111@unknownmsgid>
[not found] ` <BANLkTinNMeiimJqzFsWSS2zDggZ-o5k=fA@mail.gmail.com>
2011-06-06 9:12 ` David Jander [this message]
[not found] <-3144470533789149426@unknownmsgid>
2011-06-02 13:30 ` [PATCH] INPUT: gpio_keys.c: Added OF support and enabled use with I2C GPIO expanders Grant Likely
2011-06-06 13:39 ` David Jander
[not found] <1306919273-26815-1-git-send-email-y>
2011-06-01 9:16 ` David Jander
2011-06-01 9:07 y
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606111244.406f0cd3@archvile \
--to=david.jander@protonic.nl \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-input@vger.kernel.org \
--cc=omaplinuxkernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).