* [PATCH] input/keyboard: Remove obsolete cleanup for clientdata
@ 2011-06-20 21:01 Wolfram Sang
[not found] ` <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2011-06-20 21:01 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: Wolfram Sang, Dmitry Torokhov, Bo Shen, Axel Lin,
linux-input-u79uwXL29TY76Z2rM5mHXA
A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.
Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Bo Shen <voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
This is more a cleanup than a bugfix. Still, would be happy to have this
obsolete programming style largely removed in 3.0 if possible.
drivers/input/keyboard/qt1070.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c
index ca7b891..b21bf5b 100644
--- a/drivers/input/keyboard/qt1070.c
+++ b/drivers/input/keyboard/qt1070.c
@@ -239,8 +239,6 @@ static int __devexit qt1070_remove(struct i2c_client *client)
input_unregister_device(data->input);
kfree(data);
- i2c_set_clientdata(client, NULL);
-
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* Re: [PATCH] input/keyboard: Remove obsolete cleanup for clientdata [not found] ` <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2011-06-21 8:55 ` Jean Delvare 2011-06-21 10:40 ` Dmitry Torokhov 0 siblings, 1 reply; 3+ messages in thread From: Jean Delvare @ 2011-06-21 8:55 UTC (permalink / raw) To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Dmitry Torokhov, Bo Shen, Axel Lin, linux-input-u79uwXL29TY76Z2rM5mHXA On Mon, 20 Jun 2011 23:01:12 +0200, Wolfram Sang wrote: > A few new i2c-drivers came into the kernel which clear the clientdata-pointer > on exit or error. This is obsolete meanwhile, the core will do it. > > Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > Cc: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > Cc: Bo Shen <voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> > Cc: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> > --- > > This is more a cleanup than a bugfix. Still, would be happy to have this > obsolete programming style largely removed in 3.0 if possible. > > drivers/input/keyboard/qt1070.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c > index ca7b891..b21bf5b 100644 > --- a/drivers/input/keyboard/qt1070.c > +++ b/drivers/input/keyboard/qt1070.c > @@ -239,8 +239,6 @@ static int __devexit qt1070_remove(struct i2c_client *client) > input_unregister_device(data->input); > kfree(data); > > - i2c_set_clientdata(client, NULL); > - > return 0; > } > -- Jean Delvare ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] input/keyboard: Remove obsolete cleanup for clientdata 2011-06-21 8:55 ` Jean Delvare @ 2011-06-21 10:40 ` Dmitry Torokhov 0 siblings, 0 replies; 3+ messages in thread From: Dmitry Torokhov @ 2011-06-21 10:40 UTC (permalink / raw) To: Jean Delvare; +Cc: Wolfram Sang, linux-i2c, Bo Shen, Axel Lin, linux-input On Tue, Jun 21, 2011 at 10:55:32AM +0200, Jean Delvare wrote: > On Mon, 20 Jun 2011 23:01:12 +0200, Wolfram Sang wrote: > > A few new i2c-drivers came into the kernel which clear the clientdata-pointer > > on exit or error. This is obsolete meanwhile, the core will do it. > > > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Cc: Bo Shen <voice.shen@atmel.com> > > Cc: Axel Lin <axel.lin@gmail.com> > > Acked-by: Jean Delvare <khali@linux-fr.org> > Applied, thanks Wolfram. -- Dmitry ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-21 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-20 21:01 [PATCH] input/keyboard: Remove obsolete cleanup for clientdata Wolfram Sang
[not found] ` <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-21 8:55 ` Jean Delvare
2011-06-21 10:40 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).