From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
ARM Kernel <linux-arm-kernel@lists.infradead.org>,
linux-input@vger.kernel.org, linux-fbdev@vger.kernel.org,
rpurdie@rpsys.net, lethal@linux-sh.org, tglx@linutronix.de,
buytenh@secretlab.ca, Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH] locomo: drop special locomo_{read/write}l in favor of io{read/write}16
Date: Tue, 21 Jun 2011 03:41:49 -0700 [thread overview]
Message-ID: <20110621104148.GB8468@core.coreip.homeip.net> (raw)
In-Reply-To: <201106201454.18070.hartleys@visionengravers.com>
On Mon, Jun 20, 2011 at 02:54:17PM -0700, H Hartley Sweeten wrote:
> All the locomo registers are 16-bit ioremap'ed memory addresses.
>
> Make the locomo drivers use generic purpose io routines: ioread16
> and iowrite16 instead of directly accessing memory.
>
> There are still a couple checkpatch warnings about lines exceeding
> 79 characters.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Input parts look good to me.
Acked-by: Dmitry Torokhov <dtor@mail.ru>
--
Dmitry
prev parent reply other threads:[~2011-06-21 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 21:54 [PATCH] locomo: drop special locomo_{read/write}l in favor of io{read/write}16 H Hartley Sweeten
2011-06-21 10:41 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621104148.GB8468@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=buytenh@secretlab.ca \
--cc=hartleys@visionengravers.com \
--cc=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).