From: Wolfram Sang <w.sang@pengutronix.de>
To: linux-input@vger.kernel.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: wm97xx_read_aux_adc() for battery & pen down?
Date: Fri, 24 Jun 2011 15:00:49 +0200 [thread overview]
Message-ID: <20110624130049.GA9374@pengutronix.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]
Hi,
I have one question I got while hacking on this cheap tablet thingie I don't
have schematics or documentation for. It uses a WM9715 for (at least) touch and
battery-status, but I need the following dirty hack for 3.0-rc4 in
wm97xx_read_aux_adc():
...
- if (!(*sample & WM97XX_PEN_DOWN)) {
+ /* HACK! Disable check for battery channel on Jaytech PID7901 */
+ if ((adcsel != 0x6000) && !(*sample & WM97XX_PEN_DOWN)) {
wm->pen_probably_down = 0;
return RC_PENUP;
}
return RC_VALID;
}
So, it uses WM97XX_AUX_ID3 as the battery channel which never sets PEN_DOWN. As
a result, I always see timeouts when reading the current voltage (without the
patch). My question is: How to avoid this hack? Did I forget to configure
something somewhere? I read through the wm9715-docs and the driver source, yet
I think I missed something (or the current implementation cannot work?).
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next reply other threads:[~2011-06-24 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 13:00 Wolfram Sang [this message]
2011-06-24 16:52 ` wm97xx_read_aux_adc() for battery & pen down? Mark Brown
2011-06-24 16:58 ` Wolfram Sang
2011-06-26 11:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110624130049.GA9374@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).