From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Igor Grinberg <grinberg@compulab.co.il>
Cc: Stanislav Brabec <utx@penguin.cz>,
Marek Vasut <marek.vasut@gmail.com>,
linux-arm-kernel@lists.infradead.org,
zaurus-devel@lists.linuxtogo.org,
spi-devel-general@lists.sourceforge.net, vapier@gentoo.org,
khilman@deeprootsystems.com, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org, pavel@ucw.cz,
linux-input@vger.kernel.org, eric.y.miao@gmail.com,
akpm@linux-foundation.org
Subject: Re: kernel panic in spi_complete() on spitz (PXA270)
Date: Thu, 30 Jun 2011 08:59:58 -0700 [thread overview]
Message-ID: <20110630155957.GF3249@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4E0C957F.8080807@compulab.co.il>
On Thu, Jun 30, 2011 at 06:25:51PM +0300, Igor Grinberg wrote:
> On 06/30/11 17:45, Stanislav Brabec wrote:
> > from this thread. Without it, ADS7846 does not work on spitz (ADS7846
> > does not have any dedicated regulator there). I want to
> > add .needs_regulator bool to ads7846.c and send the patch again to the
> > list.
> Please, don't...
> I thought we've finished discussing the regulator issue...
> Instead of patching the driver and the platform data and the board file,
> you should do _either_ of the following:
> 1) add regulator definition for ads7846 into the board file
> 2) enable the CONFIG_REGULATOR_DUMMY in your kernel configuration
> 3) use regulator_use_dummy_regulator() call in the board file.
> Using either of the above, you will not need the patch for ads7846, only for the board file.
Yes, we've been through this repeatedly. None of these options take any
appreciable time to implement, it'd be much more productive to just do
so.
next prev parent reply other threads:[~2011-06-30 16:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1308845380.4533.54.camel@oct.suse.cz>
2011-06-30 11:52 ` kernel panic in spi_complete() on spitz (PXA270) Marek Vasut
[not found] ` <201106301352.21684.marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-06-30 14:45 ` Stanislav Brabec
2011-06-30 15:09 ` Marek Vasut
2011-06-30 15:36 ` Pavel Herrmann
2011-06-30 16:22 ` Stanislav Brabec
2011-06-30 15:25 ` Igor Grinberg
2011-06-30 15:59 ` Mark Brown [this message]
[not found] ` <4E0C957F.8080807-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-06-30 16:13 ` Stanislav Brabec
2011-06-30 17:40 ` Igor Grinberg
2011-06-30 18:01 ` Mark Brown
2011-06-30 20:50 ` Igor Grinberg
[not found] ` <4E0CE189.1020000-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-06-30 22:20 ` Stanislav Brabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630155957.GF3249@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=grinberg@compulab.co.il \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=pavel@ucw.cz \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=utx@penguin.cz \
--cc=vapier@gentoo.org \
--cc=zaurus-devel@lists.linuxtogo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).