From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 11/11] misc: Add slave driver for bma085 pressure sensor Date: Fri, 1 Jul 2011 10:47:28 +0200 Message-ID: <20110701104728.3ad9a670@endymion.delvare> References: <1309486707-1658-1-git-send-email-nroyer@invensense.com> <1309486707-1658-11-git-send-email-nroyer@invensense.com> <20110701085604.0aabd6f1@bob.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from zone0.gcu-squad.org ([212.85.147.21]:11963 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755447Ab1GAIrz convert rfc822-to-8bit (ORCPT ); Fri, 1 Jul 2011 04:47:55 -0400 In-Reply-To: <20110701085604.0aabd6f1@bob.linux.org.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Nathan Royer Cc: Alan Cox , Andrew Morton , Greg Kroah-Hartman , Jonathan Cameron , Jiri Kosina , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org On Fri, 1 Jul 2011 08:56:04 +0100, Alan Cox wrote: > The slave devices all appear to be generic i2c interface hardware. I > don't see why they are separate special slave devices to your driver, > they should simply be i=B2c drivers so they can be used when those > devices are found without the mpu3050. Seconded. As a matter of fact, we already have a driver for the AK8975 magnetometer: drivers/staging/iio/magnetometer/ak8975.c --=20 Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html