From: David Jander <david.jander@protonic.nl>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
David Jander <david@protonic.nl>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v5 1/2] Input: gpio_keys.c: Added support for device-tree platform data
Date: Mon, 4 Jul 2011 08:56:51 +0200 [thread overview]
Message-ID: <20110704085651.6408dcbc@archvile> (raw)
In-Reply-To: <94bc67c6-6a34-43f0-b88f-8a4278115730@email.android.com>
On Mon, 04 Jul 2011 10:52:55 +0400
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> David Jander <david.jander@protonic.nl> wrote:
>
> >On Thu, 23 Jun 2011 11:01:22 -0700
> >Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> >
> >> On Thu, Jun 23, 2011 at 07:25:37AM -0600, Grant Likely wrote:
> >> > On Thu, Jun 23, 2011 at 6:39 AM, Alan Cox
> ><alan@lxorguk.ukuu.org.uk> wrote:
> >> > >> > + - gpios: OF devcie-tree gpio specificatin.
> >> > >> > + - label: Descriptive name of the key.
> >> > >> > + - linux,code: Keycode to emit.
> >> > >>
> >> > >> The fact that this is the Linux internal keycode definitions
> >still
> >> > >> makes me nervous. Is there no existing standard for keycodes
> >emitted
> >> > >> by keyboard devices?
> >> > >
> >> > > There is but no standard lookup table. For Intel MID we do a
> >translation
> >> > > between Linux key names in the firmware and keycodes but there
> >isn't a
> >> > > generic helper for it.
> >> >
> >> > I suppose the Linux keycodes are exported out to userspace, and are
> >> > therefore an ABI which will not change. Okay.
> >>
> >> Right, keycodes form ABI that will not change.
> >>
> >> Another option would be to use codes from HID usage tables but then
> >> they would have to be translated to Linux ones.
> >
> >Dmitry, will you accept this patch also?
> >Until now, part 2/2 is in your tree, thanks for that, but I'd like to
> >know if
> >this part (1/2) will also be accepted?
> >
>
> Yes, I will since there was no more discussion about hid codes and I do
> believe that using linux definitions is fine.
Ok, thanks.
Best regards,
--
David Jander
Protonic Holland.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-04 6:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 10:04 [PATCH v5 0/2] Input: gpio_keys.c: Add support for OF and I2C GPIO chips David Jander
2011-06-23 10:04 ` [PATCH v5 1/2] Input: gpio_keys.c: Added support for device-tree platform data David Jander
2011-06-23 12:29 ` Grant Likely
2011-06-23 12:39 ` Alan Cox
2011-06-23 13:25 ` Grant Likely
2011-06-23 14:09 ` David Jander
2011-06-23 18:01 ` Dmitry Torokhov
2011-07-04 6:29 ` David Jander
2011-07-04 6:52 ` Dmitry Torokhov
2011-07-04 6:56 ` David Jander [this message]
2011-07-04 17:28 ` Dmitry Torokhov
2011-07-05 8:16 ` David Jander
2011-06-23 10:04 ` [PATCH v5 2/2] Input: gpio_keys.c: Enable use with non-local GPIO chips David Jander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704085651.6408dcbc@archvile \
--to=david.jander@protonic.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=david@protonic.nl \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).