* [PATCH 1/4] input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level
@ 2011-06-25 0:14 Ping Cheng
2011-07-01 5:18 ` Henrik Rydberg
0 siblings, 1 reply; 4+ messages in thread
From: Ping Cheng @ 2011-06-25 0:14 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, Ping Cheng, Ping Cheng
Instead of 512.
Reported-by: David Foley <favux.is@gmail.com>
Signed-off-by: Ping Cheng <pingc@wacom.com>
---
drivers/input/tablet/wacom_wac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 2ea0d2e..1cbb9a8 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -1462,7 +1462,7 @@ static const struct wacom_features wacom_features_0xD3 =
{ "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN, 21648, 13530, 1023,
63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
static const struct wacom_features wacom_features_0xD4 =
- { "Wacom Bamboo Pen", WACOM_PKGLEN_BBFUN, 14720, 9200, 255,
+ { "Wacom Bamboo Pen", WACOM_PKGLEN_BBFUN, 14720, 9200, 1023,
63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
static const struct wacom_features wacom_features_0xD6 =
{ "Wacom BambooPT 2FG 4x5", WACOM_PKGLEN_BBFUN, 14720, 9200, 1023,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/4] input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level
2011-06-25 0:14 Ping Cheng
@ 2011-07-01 5:18 ` Henrik Rydberg
0 siblings, 0 replies; 4+ messages in thread
From: Henrik Rydberg @ 2011-07-01 5:18 UTC (permalink / raw)
To: Ping Cheng; +Cc: linux-input, dmitry.torokhov, Ping Cheng
Hi Ping,
On Fri, Jun 24, 2011 at 05:14:58PM -0700, Ping Cheng wrote:
> Instead of 512.
>
> Reported-by: David Foley <favux.is@gmail.com>
> Signed-off-by: Ping Cheng <pingc@wacom.com>
> ---
Perhaps one could elaborate the commit message a bit - in particular
since the text mentions 512, whereas the patch seems to change from
256?
> drivers/input/tablet/wacom_wac.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
> index 2ea0d2e..1cbb9a8 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -1462,7 +1462,7 @@ static const struct wacom_features wacom_features_0xD3 =
> { "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN, 21648, 13530, 1023,
> 63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> static const struct wacom_features wacom_features_0xD4 =
> - { "Wacom Bamboo Pen", WACOM_PKGLEN_BBFUN, 14720, 9200, 255,
> + { "Wacom Bamboo Pen", WACOM_PKGLEN_BBFUN, 14720, 9200, 1023,
> 63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
> static const struct wacom_features wacom_features_0xD6 =
> { "Wacom BambooPT 2FG 4x5", WACOM_PKGLEN_BBFUN, 14720, 9200, 1023,
> --
Thanks,
Henrik
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/4] input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level
@ 2011-07-01 15:59 Ping Cheng
2011-07-04 10:20 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Ping Cheng @ 2011-07-01 15:59 UTC (permalink / raw)
To: rydberg; +Cc: dmitry.torokhov, linux-input
On Thu, Jun 30, 2011 at 10:18 PM, Henrik Rydberg <rydberg@euromail.se> wrote:
> Hi Ping,
> On Fri, Jun 24, 2011 at 05:14:58PM -0700, Ping Cheng wrote:
>> Instead of 512.
>>
>> Reported-by: David Foley <favux.is@gmail.com>
>> Signed-off-by: Ping Cheng <pingc@wacom.com>
>> ---
> Perhaps one could elaborate the commit message a bit - in particular
> since the text mentions 512, whereas the patch seems to change from
> 256?
Nice catch, Henrik. 512 was a typo. Does this commit message work:
It is reported by Ubuntu users that Wacom Bamboo Pen D4 has 1024
pressure level instead of 256.
Ping
>> drivers/input/tablet/wacom_wac.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
>> index 2ea0d2e..1cbb9a8 100644
>> --- a/drivers/input/tablet/wacom_wac.c
>> +++ b/drivers/input/tablet/wacom_wac.c
>> @@ -1462,7 +1462,7 @@ static const struct wacom_features wacom_features_0xD3 =
>> { "Wacom Bamboo 2FG 6x8", WACOM_PKGLEN_BBFUN, 21648, 13530, 1023,
>> 63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>> static const struct wacom_features wacom_features_0xD4 =
>> - { "Wacom Bamboo Pen", WACOM_PKGLEN_BBFUN, 14720, 9200, 255,
>> + { "Wacom Bamboo Pen", WACOM_PKGLEN_BBFUN, 14720, 9200, 1023,
>> 63, BAMBOO_PT, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
>> static const struct wacom_features wacom_features_0xD6 =
>> { "Wacom BambooPT 2FG 4x5", WACOM_PKGLEN_BBFUN, 14720, 9200, 1023,
>> --
>
> Thanks,
> Henrik
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/4] input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level
2011-07-01 15:59 [PATCH 1/4] input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level Ping Cheng
@ 2011-07-04 10:20 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2011-07-04 10:20 UTC (permalink / raw)
To: Ping Cheng; +Cc: rydberg, linux-input
On Fri, Jul 01, 2011 at 08:59:51AM -0700, Ping Cheng wrote:
> On Thu, Jun 30, 2011 at 10:18 PM, Henrik Rydberg <rydberg@euromail.se> wrote:
>
> > Hi Ping,
>
> > On Fri, Jun 24, 2011 at 05:14:58PM -0700, Ping Cheng wrote:
> >> Instead of 512.
> >>
> >> Reported-by: David Foley <favux.is@gmail.com>
> >> Signed-off-by: Ping Cheng <pingc@wacom.com>
> >> ---
>
> > Perhaps one could elaborate the commit message a bit - in particular
> > since the text mentions 512, whereas the patch seems to change from
> > 256?
>
> Nice catch, Henrik. 512 was a typo. Does this commit message work:
>
> It is reported by Ubuntu users that Wacom Bamboo Pen D4 has 1024
> pressure level instead of 256.
Unfortunately I already pushed out the patch to we'll have to live with
bad log message. Oh well...
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-04 10:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-01 15:59 [PATCH 1/4] input: wacom - Wacom Bamboo Pen D4 has 1024 pressure level Ping Cheng
2011-07-04 10:20 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2011-06-25 0:14 Ping Cheng
2011-07-01 5:18 ` Henrik Rydberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).