From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chris Moeller <kode54@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 2.6.38.7 3/3] xpad: wireless LED setting
Date: Mon, 4 Jul 2011 15:32:28 -0700 [thread overview]
Message-ID: <20110704223228.GA2724@core.coreip.homeip.net> (raw)
In-Reply-To: <1307926190.8254.21.camel@sabin.lan>
Hi Chris,
On Sun, Jun 12, 2011 at 05:49:49PM -0700, Chris Moeller wrote:
> + } else if (xpad->xtype == XTYPE_XBOX360W) {
> + if (command >= 0 && command < 16) {
> + if (command == 16)
> + command = 2 + (xpad->interface_number & 6) / 2;
Not commenting on the rest of the patch, but this chunk does not make
sense - you go into this branch only if command is less than 16 so it
can never be equal to 16 in the nested 'if'.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-07-05 4:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 0:49 [PATCH 2.6.38.7 3/3] xpad: wireless LED setting Chris Moeller
2011-07-04 22:32 ` Dmitry Torokhov [this message]
2011-07-04 23:52 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704223228.GA2724@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=kode54@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).