From: "Henrik Rydberg" <rydberg@euromail.se>
To: Chris Bagwell <chris@cnpbagwell.com>
Cc: Ping Cheng <pinglinux@gmail.com>,
linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
Ping Cheng <pingc@wacom.com>
Subject: Re: [PATCH 3/3 v2] input : wacom - Cleanup a return value for the old Bamboo
Date: Wed, 6 Jul 2011 07:52:09 +0200 [thread overview]
Message-ID: <20110706055209.GA30776@polaris.bitmath.org> (raw)
In-Reply-To: <CAGzDe_Ya8sFhr=h04vhtGqisbHKf7OFA+n=XVGuFo_tf2NVkWA@mail.gmail.com>
On Tue, Jul 05, 2011 at 09:34:08PM -0500, Chris Bagwell wrote:
> On Tue, Jul 5, 2011 at 6:26 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> > The old code may call input_sync without sending any other events.
> > Although the sync event will be ignored in the userland, eliminating
> > unnecessary kernel events is the right way to go.
>
> Aligns the code block with previous case statement as well.
>
> Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
The sync will not even reach userland, but the patch wont hurt. For
all patches in the set:
Reviewed-by: Henrik Rydberg <rydberg@euromail.se>
Thanks Ping, thanks Chris.
Henrik
next prev parent reply other threads:[~2011-07-06 5:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 23:26 [PATCH 3/3 v2] input : wacom - Cleanup a return value for the old Bamboo Ping Cheng
2011-07-06 2:34 ` Chris Bagwell
2011-07-06 5:52 ` Henrik Rydberg [this message]
2011-07-07 5:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706055209.GA30776@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pingc@wacom.com \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).