* [PATCH 3/3 v2] input : wacom - Cleanup a return value for the old Bamboo
@ 2011-07-05 23:26 Ping Cheng
2011-07-06 2:34 ` Chris Bagwell
0 siblings, 1 reply; 4+ messages in thread
From: Ping Cheng @ 2011-07-05 23:26 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, rydberg, Ping Cheng, Ping Cheng
The old code may call input_sync without sending any other events.
Although the sync event will be ignored in the userland, eliminating
unnecessary kernel events is the right way to go.
Signed-off-by: Ping Cheng <pingc@wacom.com>
---
drivers/input/tablet/wacom_wac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index 19554a4..03ebcc8 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -300,8 +300,8 @@ static int wacom_graphire_irq(struct wacom_wac *wacom)
wacom->id[1] = 0;
input_report_abs(input, ABS_MISC, wacom->id[1]);
input_event(input, EV_MSC, MSC_SERIAL, 0xf0);
+ retval = 1;
}
- retval = 1;
break;
}
exit:
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3 v2] input : wacom - Cleanup a return value for the old Bamboo
2011-07-05 23:26 [PATCH 3/3 v2] input : wacom - Cleanup a return value for the old Bamboo Ping Cheng
@ 2011-07-06 2:34 ` Chris Bagwell
2011-07-06 5:52 ` Henrik Rydberg
0 siblings, 1 reply; 4+ messages in thread
From: Chris Bagwell @ 2011-07-06 2:34 UTC (permalink / raw)
To: Ping Cheng; +Cc: linux-input, dmitry.torokhov, rydberg, Ping Cheng
On Tue, Jul 5, 2011 at 6:26 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> The old code may call input_sync without sending any other events.
> Although the sync event will be ignored in the userland, eliminating
> unnecessary kernel events is the right way to go.
Aligns the code block with previous case statement as well.
Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
>
> Signed-off-by: Ping Cheng <pingc@wacom.com>
> ---
> drivers/input/tablet/wacom_wac.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
> index 19554a4..03ebcc8 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -300,8 +300,8 @@ static int wacom_graphire_irq(struct wacom_wac *wacom)
> wacom->id[1] = 0;
> input_report_abs(input, ABS_MISC, wacom->id[1]);
> input_event(input, EV_MSC, MSC_SERIAL, 0xf0);
> + retval = 1;
> }
> - retval = 1;
> break;
> }
> exit:
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3 v2] input : wacom - Cleanup a return value for the old Bamboo
2011-07-06 2:34 ` Chris Bagwell
@ 2011-07-06 5:52 ` Henrik Rydberg
2011-07-07 5:19 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Henrik Rydberg @ 2011-07-06 5:52 UTC (permalink / raw)
To: Chris Bagwell; +Cc: Ping Cheng, linux-input, dmitry.torokhov, Ping Cheng
On Tue, Jul 05, 2011 at 09:34:08PM -0500, Chris Bagwell wrote:
> On Tue, Jul 5, 2011 at 6:26 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> > The old code may call input_sync without sending any other events.
> > Although the sync event will be ignored in the userland, eliminating
> > unnecessary kernel events is the right way to go.
>
> Aligns the code block with previous case statement as well.
>
> Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
The sync will not even reach userland, but the patch wont hurt. For
all patches in the set:
Reviewed-by: Henrik Rydberg <rydberg@euromail.se>
Thanks Ping, thanks Chris.
Henrik
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 3/3 v2] input : wacom - Cleanup a return value for the old Bamboo
2011-07-06 5:52 ` Henrik Rydberg
@ 2011-07-07 5:19 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2011-07-07 5:19 UTC (permalink / raw)
To: Henrik Rydberg; +Cc: Chris Bagwell, Ping Cheng, linux-input, Ping Cheng
On Wed, Jul 06, 2011 at 07:52:09AM +0200, Henrik Rydberg wrote:
> On Tue, Jul 05, 2011 at 09:34:08PM -0500, Chris Bagwell wrote:
> > On Tue, Jul 5, 2011 at 6:26 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> > > The old code may call input_sync without sending any other events.
> > > Although the sync event will be ignored in the userland, eliminating
> > > unnecessary kernel events is the right way to go.
> >
> > Aligns the code block with previous case statement as well.
> >
> > Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
>
> The sync will not even reach userland, but the patch wont hurt. For
> all patches in the set:
>
> Reviewed-by: Henrik Rydberg <rydberg@euromail.se>
>
> Thanks Ping, thanks Chris.
>
Applied all 4, thanks everyone.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-07 5:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-05 23:26 [PATCH 3/3 v2] input : wacom - Cleanup a return value for the old Bamboo Ping Cheng
2011-07-06 2:34 ` Chris Bagwell
2011-07-06 5:52 ` Henrik Rydberg
2011-07-07 5:19 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).