* [patch 1/2] input: kxtj9: fix bug in probe()
@ 2011-07-20 5:30 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2011-07-20 5:30 UTC (permalink / raw)
To: Chris Hudson; +Cc: Dmitry Torokhov, linux-input
We are testing the wrong variable here. I believe tj9->input_dev
is always NULL at this point, so probe() will fail.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Compile tested.
diff --git a/drivers/input/misc/kxtj9.c b/drivers/input/misc/kxtj9.c
index a416f7f..6c96dc3 100644
--- a/drivers/input/misc/kxtj9.c
+++ b/drivers/input/misc/kxtj9.c
@@ -301,7 +301,7 @@ static int __devinit kxtj9_setup_input_device(struct kxtj9_data *tj9)
int err;
input_dev = input_allocate_device();
- if (!tj9->input_dev) {
+ if (!input_dev) {
dev_err(&tj9->client->dev, "input device allocate failed\n");
return -ENOMEM;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-07-20 5:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-20 5:30 [patch 1/2] input: kxtj9: fix bug in probe() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).