* [PATCH] drivers:input:free the memory before set it to NULL
@ 2011-07-20 15:41 Wanlong Gao
2011-07-20 15:54 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Wanlong Gao @ 2011-07-20 15:41 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: sameo, linux-input, Wanlong Gao, Wanlong Gao
The memory of the platform driver data should be freed
before it was set to NULL.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
drivers/input/misc/pmic8xxx-pwrkey.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c
index b3cfb9c..2f3ca73 100644
--- a/drivers/input/misc/pmic8xxx-pwrkey.c
+++ b/drivers/input/misc/pmic8xxx-pwrkey.c
@@ -198,8 +198,8 @@ static int __devexit pmic8xxx_pwrkey_remove(struct platform_device *pdev)
free_irq(key_press_irq, pwrkey);
free_irq(key_release_irq, pwrkey);
input_unregister_device(pwrkey->pwr);
- platform_set_drvdata(pdev, NULL);
kfree(pwrkey);
+ platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:input:free the memory before set it to NULL
2011-07-20 15:41 [PATCH] drivers:input:free the memory before set it to NULL Wanlong Gao
@ 2011-07-20 15:54 ` Alan Cox
2011-07-20 16:08 ` Wanlong Gao
2011-07-20 16:11 ` Wanlong Gao
0 siblings, 2 replies; 4+ messages in thread
From: Alan Cox @ 2011-07-20 15:54 UTC (permalink / raw)
To: Wanlong Gao; +Cc: dmitry.torokhov, sameo, linux-input, Wanlong Gao
On Wed, 20 Jul 2011 23:41:36 +0800
Wanlong Gao <wanlong.gao@gmail.com> wrote:
> The memory of the platform driver data should be freed
> before it was set to NULL.
This seems backwards to me. Currently the reference is invalidated before
the object, which seems to make more sense.
As there is no locking here it really makes no difference anyway
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:input:free the memory before set it to NULL
2011-07-20 15:54 ` Alan Cox
@ 2011-07-20 16:08 ` Wanlong Gao
2011-07-20 16:11 ` Wanlong Gao
1 sibling, 0 replies; 4+ messages in thread
From: Wanlong Gao @ 2011-07-20 16:08 UTC (permalink / raw)
To: Alan Cox; +Cc: dmitry.torokhov, sameo, linux-input, Wanlong Gao
On 三, 2011-07-20 at 16:54 +0100, Alan Cox wrote:
> On Wed, 20 Jul 2011 23:41:36 +0800
> Wanlong Gao <wanlong.gao@gmail.com> wrote:
>
> > The memory of the platform driver data should be freed
> > before it was set to NULL.
>
> This seems backwards to me. Currently the reference is invalidated before
> the object, which seems to make more sense.
>
> As there is no locking here it really makes no difference anyway
Hmm...
FYI, I see it. Thanks Alan.
And sorry for making noise.
Wanlong Gao
>
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:input:free the memory before set it to NULL
2011-07-20 15:54 ` Alan Cox
2011-07-20 16:08 ` Wanlong Gao
@ 2011-07-20 16:11 ` Wanlong Gao
1 sibling, 0 replies; 4+ messages in thread
From: Wanlong Gao @ 2011-07-20 16:11 UTC (permalink / raw)
To: Alan Cox; +Cc: dmitry.torokhov, sameo, linux-input, Wanlong Gao
On 三, 2011-07-20 at 16:54 +0100, Alan Cox wrote:
> On Wed, 20 Jul 2011 23:41:36 +0800
> Wanlong Gao <wanlong.gao@gmail.com> wrote:
>
> > The memory of the platform driver data should be freed
> > before it was set to NULL.
>
> This seems backwards to me. Currently the reference is invalidated before
> the object, which seems to make more sense.
>
> As there is no locking here it really makes no difference anyway
BTW, your email head icon is so cool.
Thanks
Wanlong Gao
>
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-20 16:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-20 15:41 [PATCH] drivers:input:free the memory before set it to NULL Wanlong Gao
2011-07-20 15:54 ` Alan Cox
2011-07-20 16:08 ` Wanlong Gao
2011-07-20 16:11 ` Wanlong Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).