From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Philippe Rétornaz" <philippe.retornaz@epfl.ch>
Cc: amit.kucheria@canonical.com, broonie@opensource.wolfsonmicro.com,
sameo@linux.intel.com, s.hauer@pengutronix.de,
dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 0/6] mc13783: add pwr button support
Date: Thu, 21 Jul 2011 16:44:42 +0200 [thread overview]
Message-ID: <20110721144442.GA16561@pengutronix.de> (raw)
In-Reply-To: <1311261006-28048-1-git-send-email-philippe.retornaz@epfl.ch>
Hello Philippe,
On Thu, Jul 21, 2011 at 05:10:00PM +0200, Philippe Rétornaz wrote:
> This add button handling for the MC13783 PMIC.
> The first patch modify the mc13783 MFD driver to add a button
> subdevice and also adds the mc13783-pwrbutton driver using a misc
> input device.
>
> The second patch adds the power on button support to the mx31moboard boards.
>
> Patch 3 & 4 modify the mc13xxx MFD driver to use the platform data to
> register the led subdevice and unconditionally register the regulator
> subdevice (as suggested by Mark and Uwe).
>
> Patch 5 remove the use of the *_USE_REGULATOR and *_USE_LED in the platform
> files.
>
> Patch 6 must be applied after patch 3,4,5 to remove the obsolete define.
>
> v2: first patch modified according to comments by Dmitry Torokhov
> v3: Implement review by Uwe
> v4: Implement comments by Uwe and Mark
>
> Philippe Rétornaz (6):
> mc13783: add power button support
> mx31moboard: Add MC13783 power button support
> mc13xxx: Unconditionally register regulator subdevice
> mc13xxx: implicitly register led subdevice
> mc13xxx: remove obsolete leds and regualtors flags
> mc13xxx: remove unused define
I think Arndt would like to have the clean up stuff first (assuming this
goes via the arm-soc tree). That is 3-6, then 1-2.
Other than that I think the series looks good now (at least the arch/arm
bits, didn't recheck the rest).
> arch/arm/mach-imx/mach-mx27_3ds.c | 1 -
> arch/arm/mach-imx/mach-mx31_3ds.c | 2 +-
> arch/arm/mach-imx/mach-mx31lite.c | 3 +-
> arch/arm/mach-imx/mach-mx31moboard.c | 11 +-
> arch/arm/mach-imx/mach-pcm038.c | 3 +-
> arch/arm/mach-mx5/mx51_efika.c | 2 +-
> drivers/input/misc/Kconfig | 10 +
> drivers/input/misc/Makefile | 1 +
> drivers/input/misc/mc13783-pwrbutton.c | 288 ++++++++++++++++++++++++++++++++
> drivers/mfd/mc13xxx-core.c | 12 +-
> include/linux/mfd/mc13783.h | 3 +-
> include/linux/mfd/mc13xxx.h | 19 ++-
> 12 files changed, 337 insertions(+), 18 deletions(-)
> create mode 100644 drivers/input/misc/mc13783-pwrbutton.c
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-07-21 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 15:10 [PATCH v4 0/6] mc13783: add pwr button support Philippe Rétornaz
2011-07-21 14:44 ` Uwe Kleine-König [this message]
2011-07-21 15:10 ` [PATCH 1/6] mc13783: add power " Philippe Rétornaz
2011-07-21 15:10 ` [PATCH 2/6] mx31moboard: Add MC13783 " Philippe Rétornaz
2011-07-21 15:10 ` [PATCH 3/6] mc13xxx: Unconditionally register regulator subdevice Philippe Rétornaz
2011-07-21 15:10 ` [PATCH 4/6] mc13xxx: implicitly register led subdevice Philippe Rétornaz
2011-07-21 15:10 ` [PATCH 5/6] mc13xxx: remove obsolete leds and regualtors flags Philippe Rétornaz
2011-07-21 15:10 ` [PATCH 6/6] mc13xxx: remove unused define Philippe Rétornaz
2011-07-22 1:39 ` [PATCH 1/6] mc13783: add power button support Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110721144442.GA16561@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=amit.kucheria@canonical.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=philippe.retornaz@epfl.ch \
--cc=s.hauer@pengutronix.de \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).