From: Greg KH <gregkh@suse.de>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Wanlong Gao <wanlong.gao@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] drivers:input:set driver data to NULL for pcap_keys
Date: Mon, 25 Jul 2011 08:21:06 -0700 [thread overview]
Message-ID: <20110725152106.GB23356@suse.de> (raw)
In-Reply-To: <4E2D33E3.9090408@cn.fujitsu.com>
On Mon, Jul 25, 2011 at 05:14:11PM +0800, Wanlong Gao wrote:
> On 07/25/2011 04:30 PM, Dmitry Torokhov wrote:
> >On Wed, Jul 20, 2011 at 11:34:28PM +0800, Wanlong Gao wrote:
> >>It's better to set the device's driver data to NULL
> >>when remove it.
> >>
> >
> >I'd rather have platform devices core clean up this pointer, then we
> >could stop caring about it in all drivers...
> But the platform devices core just call the method of each own.
> And don't care about the details like pdata, etc.
>
> Meanwhile, I think the platform core need not care about these details.
>
> and Greg, what do you think about this?
I don't understand what you are asking me.
next prev parent reply other threads:[~2011-07-25 15:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 15:34 [PATCH] drivers:input:set driver data to NULL for pcap_keys Wanlong Gao
2011-07-25 8:30 ` Dmitry Torokhov
2011-07-25 9:14 ` Wanlong Gao
2011-07-25 15:21 ` Greg KH [this message]
2011-07-25 15:34 ` Wanlong Gao
2011-07-25 18:19 ` Dmitry Torokhov
2011-07-25 18:29 ` Mark Brown
2011-07-25 18:37 ` Dmitry Torokhov
2011-07-26 1:29 ` Wanlong Gao
2011-07-26 4:39 ` Greg KH
2011-07-26 5:36 ` Wanlong Gao
2011-07-26 6:02 ` Greg KH
2011-07-26 6:25 ` Wanlong Gao
2011-07-26 6:45 ` Dmitry Torokhov
2011-07-26 16:41 ` Greg KH
2011-07-26 17:26 ` Dmitry Torokhov
2011-07-25 18:26 ` Mark Brown
2011-07-25 23:25 ` Greg KH
2011-07-26 8:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725152106.GB23356@suse.de \
--to=gregkh@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=linux-input@vger.kernel.org \
--cc=wanlong.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).