linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Wanlong Gao <wanlong.gao@gmail.com>
Cc: Greg KH <gregkh@suse.de>, Wanlong Gao <gaowanlong@cn.fujitsu.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] drivers:input:set driver data to NULL for pcap_keys
Date: Mon, 25 Jul 2011 11:19:16 -0700	[thread overview]
Message-ID: <20110725181916.GB6876@core.coreip.homeip.net> (raw)
In-Reply-To: <1311608069.3262.8.camel@Allen>

On Mon, Jul 25, 2011 at 11:34:29PM +0800, Wanlong Gao wrote:
> > > On 07/25/2011 04:30 PM, Dmitry Torokhov wrote:
> 
> > I'd rather have platform devices core clean up this pointer, then we
> > could stop caring about it in all drivers...
> > 
> 
> then I said:
> 
> > But the platform devices core just call the method of each own.
> > And don't care about the details like pdata, etc.
> > 
> > Meanwhile, I think the platform core need not care about these
> > details.
> > 
> > and Greg, what do you think about this?
> > 
> this is the thread, Greg, understand now?
> 
> For short, it's all about the platform driver data. Since many drivers
> set the platform driver data to NULL when it is removed, then Dmitry
> think it should be done in the platform driver core instead.

Right, like i2c bus we could just have platform core clean up platform
drvdata pointer after calling ->remove() and also if ->probe() errors
out.

Then individual drivers do not have to care about cleaning up this
pointer.

Thanks.

-- 
Dmitry

  reply	other threads:[~2011-07-25 18:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20 15:34 [PATCH] drivers:input:set driver data to NULL for pcap_keys Wanlong Gao
2011-07-25  8:30 ` Dmitry Torokhov
2011-07-25  9:14   ` Wanlong Gao
2011-07-25 15:21     ` Greg KH
2011-07-25 15:34       ` Wanlong Gao
2011-07-25 18:19         ` Dmitry Torokhov [this message]
2011-07-25 18:29           ` Mark Brown
2011-07-25 18:37             ` Dmitry Torokhov
2011-07-26  1:29               ` Wanlong Gao
2011-07-26  4:39                 ` Greg KH
2011-07-26  5:36                   ` Wanlong Gao
2011-07-26  6:02                     ` Greg KH
2011-07-26  6:25                       ` Wanlong Gao
2011-07-26  6:45                         ` Dmitry Torokhov
2011-07-26 16:41                           ` Greg KH
2011-07-26 17:26                             ` Dmitry Torokhov
2011-07-25 18:26       ` Mark Brown
2011-07-25 23:25         ` Greg KH
2011-07-26  8:54           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110725181916.GB6876@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=gaowanlong@cn.fujitsu.com \
    --cc=gregkh@suse.de \
    --cc=linux-input@vger.kernel.org \
    --cc=wanlong.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).