From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH 03/16] HID: wiimote: Add drm request Date: Thu, 28 Jul 2011 20:47:14 +0200 Message-ID: <201107282047.14903.oneukum@suse.de> References: <1311869316-17128-1-git-send-email-dh.herrmann@googlemail.com> <201107282005.40226.oneukum@suse.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from cantor2.suse.de ([195.135.220.15]:54918 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190Ab1G1So1 (ORCPT ); Thu, 28 Jul 2011 14:44:27 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: David Herrmann Cc: linux-input@vger.kernel.org, jkosina@suse.cz, padovan@profusion.mobi Am Donnerstag, 28. Juli 2011, 20:41:18 schrieb David Herrmann: > On Thu, Jul 28, 2011 at 8:05 PM, Oliver Neukum wrote: > > Am Donnerstag, 28. Juli 2011, 18:08:23 schrieb David Herrmann: > >> +static void wiiproto_req_drm(struct wiimote_data *wdata, __u8 drm) > >> +{ > >> + __u8 cmd[3]; > > > > Are you sure these buffers nned not be safe for DMA? > > wiimote_queue() allocates a buffer for every request. This should be > fine for DMA then. All wiimote_req_*() functions work the same way. > Yes, that's safe. Regards Oliver