linux-next: build failure after merge of the moduleh tree

linux-next: build failure after merge of the moduleh tree

[Stephen Rothwell]

Hi Paul,

After merging the moduleh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/input/misc/kxtj9.c:644:1: warning: data definition has no type or storage class
drivers/input/misc/kxtj9.c:644:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
drivers/input/misc/kxtj9.c:644:1: warning: parameter names (without types) in function declaration
drivers/input/misc/kxtj9.c:649:12: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/input/misc/kxtj9.c:669:20: error: expected declaration specifiers or '...' before string constant
drivers/input/misc/kxtj9.c:669:1: warning: data definition has no type or storage class
drivers/input/misc/kxtj9.c:669:1: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/input/misc/kxtj9.c:669:20: warning: function declaration isn't a prototype
drivers/input/misc/kxtj9.c:670:15: error: expected declaration specifiers or '...' before string constant
drivers/input/misc/kxtj9.c:670:1: warning: data definition has no type or storage class
drivers/input/misc/kxtj9.c:670:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/input/misc/kxtj9.c:670:15: warning: function declaration isn't a prototype
drivers/input/misc/kxtj9.c:671:16: error: expected declaration specifiers or '...' before string constant
drivers/input/misc/kxtj9.c:671:1: warning: data definition has no type or storage class
drivers/input/misc/kxtj9.c:671:1: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/input/misc/kxtj9.c:671:16: warning: function declaration isn't a prototype
drivers/input/misc/kxtj9.c: In function 'kxtj9_init':
drivers/input/misc/kxtj9.c:660:1: warning: control reaches end of non-void function

I have added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 29 Jul 2011 15:06:46 +1000
Subject: [PATCH] kxtj9: explictly include module.h

since some of its facilities are used.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/input/misc/kxtj9.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/input/misc/kxtj9.c b/drivers/input/misc/kxtj9.c
index c456f63..783597a 100644
--- a/drivers/input/misc/kxtj9.c
+++ b/drivers/input/misc/kxtj9.c
@@ -21,6 +21,7 @@
 #include <linux/i2c.h>
 #include <linux/input.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/input/kxtj9.h>
 #include <linux/input-polldev.h>
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the moduleh tree

[Dmitry Torokhov]

On Fri, Jul 29, 2011 at 03:10:44PM +1000, Stephen Rothwell wrote:
> Hi Paul,
> 
> After merging the moduleh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/input/misc/kxtj9.c:644:1: warning: data definition has no type or storage class
> drivers/input/misc/kxtj9.c:644:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> drivers/input/misc/kxtj9.c:644:1: warning: parameter names (without types) in function declaration
> drivers/input/misc/kxtj9.c:649:12: error: 'THIS_MODULE' undeclared here (not in a function)
> drivers/input/misc/kxtj9.c:669:20: error: expected declaration specifiers or '...' before string constant
> drivers/input/misc/kxtj9.c:669:1: warning: data definition has no type or storage class
> drivers/input/misc/kxtj9.c:669:1: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/input/misc/kxtj9.c:669:20: warning: function declaration isn't a prototype
> drivers/input/misc/kxtj9.c:670:15: error: expected declaration specifiers or '...' before string constant
> drivers/input/misc/kxtj9.c:670:1: warning: data definition has no type or storage class
> drivers/input/misc/kxtj9.c:670:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/input/misc/kxtj9.c:670:15: warning: function declaration isn't a prototype
> drivers/input/misc/kxtj9.c:671:16: error: expected declaration specifiers or '...' before string constant
> drivers/input/misc/kxtj9.c:671:1: warning: data definition has no type or storage class
> drivers/input/misc/kxtj9.c:671:1: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/input/misc/kxtj9.c:671:16: warning: function declaration isn't a prototype
> drivers/input/misc/kxtj9.c: In function 'kxtj9_init':
> drivers/input/misc/kxtj9.c:660:1: warning: control reaches end of non-void function
> 
> I have added this patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 29 Jul 2011 15:06:46 +1000
> Subject: [PATCH] kxtj9: explictly include module.h
> 
> since some of its facilities are used.
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Applied, thanks Stephen.

-- 
Dmitry