From: Grant Likely <grant.likely@secretlab.ca>
To: Michal Simek <monstr@monstr.eu>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] input: xilinx_ps2: Add missing of_address.h header
Date: Sat, 30 Jul 2011 22:12:30 -0600 [thread overview]
Message-ID: <20110731041230.GO24334@ponder.secretlab.ca> (raw)
In-Reply-To: <4E2C2362.1080204@monstr.eu>
On Sun, Jul 24, 2011 at 03:51:30PM +0200, Michal Simek wrote:
> Hi Grant,
>
> can you propose this patch to mainline through your devicetree tree?
I've got it in a "input/next" branch. Since the input maintainer
doesn't seem to be active on driver patches, I'll send a pull req to
Linus.
g.
>
> Thanks,
> Michal
>
> Grant Likely wrote:
> >On Wed, Jul 13, 2011 at 10:46 PM, Michal Simek <monstr@monstr.eu> wrote:
> >>Add missing header.
> >>
> >>Error log:
> >>CC drivers/input/serio/xilinx_ps2.o
> >>drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
> >>drivers/input/serio/xilinx_ps2.c:249: error: implicit declaration of function 'of_address_to_resource'
> >>
> >>Signed-off-by: Michal Simek <monstr@monstr.eu>
> >
> >Acked-by: Grant Likely <grant.likely@secretlab.ca>
> >
> >>---
> >> drivers/input/serio/xilinx_ps2.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >>diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
> >>index 80baa53..d64c5a4 100644
> >>--- a/drivers/input/serio/xilinx_ps2.c
> >>+++ b/drivers/input/serio/xilinx_ps2.c
> >>@@ -23,7 +23,7 @@
> >> #include <linux/init.h>
> >> #include <linux/list.h>
> >> #include <linux/io.h>
> >>-
> >>+#include <linux/of_address.h>
> >> #include <linux/of_device.h>
> >> #include <linux/of_platform.h>
> >>
> >>--
> >>1.5.5.6
> >>
> >>
> >
> >
> >
>
>
> --
> Michal Simek, Ing. (M.Eng)
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
> Microblaze U-BOOT custodian
next prev parent reply other threads:[~2011-07-31 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 13:46 [PATCH] input: xilinx_ps2: Add missing of_address.h header Michal Simek
2011-07-13 15:27 ` Grant Likely
2011-07-24 13:51 ` Michal Simek
2011-07-31 4:12 ` Grant Likely [this message]
2011-08-01 3:10 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110731041230.GO24334@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).