From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Barry Song <21cnbao@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Liam Girdwood <lrg@ti.com>,
Grant Likely <grant.likely@secretlab.ca>,
alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org,
linux-input@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Add device tree binding for WM8753
Date: Wed, 10 Aug 2011 13:51:19 +0900 [thread overview]
Message-ID: <20110810045113.GA23625@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAGsJ_4w-YhWQTFovkynKVVr6JkwcHJQn-EmfxUxOSd=C2BwhiA@mail.gmail.com>
On Wed, Aug 10, 2011 at 09:21:16AM +0800, Barry Song wrote:
> 2011/8/9 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> > Oh, if that's the case the driver ought to have device tree bindings
> > which replicate the platform data. Unless the platform data is
> > sufficiently obscure for hardly anyone to want to use it I guess.
> I guess what Dmitry said is the big ads7846_platform_data structure.
Yes.
> struct ads7846_platform_data {
> u16 model; /* 7843, 7845, 7846, 7873. */
> u16 vref_delay_usecs; /* 0 for external vref; etc */
> u16 vref_mv; /* external vref value, milliVolts
> * ads7846: if 0, use internal vref */
> bool keep_vref_on; /* set to keep vref on for differential
> * measurements as well */
> bool swap_xy; /* swap x and y axes */
...
> The structure even has some callbacks which can't be possible in dts.
There's some callbacks but the bulk of the structure (including the bits
I quoted above for example) looks like it's pure data and could sensibly
be represented in the device tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-10 4:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1312778255-29755-1-git-send-email-broonie@opensource.wolfsonmicro.com>
2011-08-08 8:38 ` [alsa-devel] [PATCH] ASoC: Add device tree binding for WM8753 Barry Song
2011-08-08 8:55 ` Mark Brown
2011-08-09 6:51 ` Dmitry Torokhov
2011-08-09 14:28 ` Mark Brown
2011-08-10 1:21 ` [alsa-devel] " Barry Song
2011-08-10 4:51 ` Mark Brown [this message]
2011-08-10 5:57 ` Barry Song
2011-08-10 6:30 ` Mark Brown
2011-08-12 3:16 ` Barry Song
2011-08-12 3:53 ` Dmitry Torokhov
2011-08-12 4:35 ` Barry Song
2011-08-12 4:41 ` [alsa-devel] " Mark Brown
2011-08-12 5:57 ` Dmitry Torokhov
2011-08-12 6:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810045113.GA23625@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=21cnbao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-input@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).