From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ping Cheng <pinglinux@gmail.com>
Cc: Chris Bagwell <chris@cnpbagwell.com>,
linux-input@vger.kernel.org, Jason Gerecke <killertofu@gmail.com>
Subject: Re: [PATCH 2/5] input: wacom - remove pressure for touch devices
Date: Wed, 17 Aug 2011 09:21:59 -0700 [thread overview]
Message-ID: <20110817162159.GA4877@core.coreip.homeip.net> (raw)
In-Reply-To: <CAF8JNh+dpmh50ixyNKtVNL-ZGVZg3rfjbyvnVAi790nwvFCJVA@mail.gmail.com>
On Wed, Aug 17, 2011 at 08:32:28AM -0700, Ping Cheng wrote:
> On Tue, Aug 16, 2011 at 11:50 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com
> > wrote:
>
> > On Mon, Aug 15, 2011 at 09:34:23PM -0700, Ping Cheng wrote:
> > > On Sun, Aug 14, 2011 at 8:27 PM, Chris Bagwell <chris@cnpbagwell.com>
> > wrote:
> > >
> > > > On Fri, Aug 12, 2011 at 7:08 PM, Ping Cheng <pinglinux@gmail.com>
> > wrote:
> > > > > Touch devices do not report valid pressure or capacitance.
> > > > >
> > > > > Signed-off-by: Ping Cheng <pingc@wacom.com>
> > > > > ---
> > > >
> > > > I'd prefer if we kept pressure support. At least for Bamboo's with
> > > > product ID between 0xd0 and 0xd4.
> > > >
> > > > In my testing of an 0xd1 device, pressure works fine (low pressure and
> > > > high pressure work great. Not much middle pressure sensitivity.
> > > > Multi-touch will increase pressure reading. All pretty common
> > > > behaviour).
> > > >
> > >
> > > Basically, there were three reasons to remove the pressure bit for all
> > touch
> > > devices:
> > >
> > > 1. The value is not a pressure and it does not report valid capacitance
> > > either;
> > > 2. The only valid use in the kernel driver is to decide if the finger
> > is
> > > touching the tablet or not, which has already been correctly reported by
> > the
> > > firmware in the other bits. So, it is redundant to check the pressure for
> > > this purpose;
> > > 3. Passing the invalid "pressure" to the user land would only introduce
> > > bad user experience since touch is not designed for drawing. We don't
> > want
> > > to confuse user with that "pressure".
> >
> > Not speaking about touch per se, but pressure is important for other
> > things besides drawing. Different people prefer different device
> > sensitivity and if userspace knows pressure it can adjust according to
> > user preference, like synaptics X driver does with touchpads that
> > actually report it. I believe tslib allows similar for touchscreens.
> >
>
> Your suggestion is based on the assumption that the value is pressure.
I did not make any assumptions, I was just making general observation
that if pressure data is available it is useful not only for drawing
applications.
> But
> that is not true. The value is not pressure and it is unreliable.
So what is this data then?
Thanks.
--
Dmitry
prev parent reply other threads:[~2011-08-17 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 0:08 [PATCH 2/5] input: wacom - remove pressure for touch devices Ping Cheng
2011-08-15 3:27 ` Chris Bagwell
[not found] ` <CAF8JNh+90K2Qfpzu9Rwt_cdvqxTxaF8iJJ2-=nmWY8qLL6Wmzg@mail.gmail.com>
2011-08-17 6:50 ` Dmitry Torokhov
[not found] ` <CAF8JNh+dpmh50ixyNKtVNL-ZGVZg3rfjbyvnVAi790nwvFCJVA@mail.gmail.com>
2011-08-17 16:21 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817162159.GA4877@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chris@cnpbagwell.com \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).