From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seth Forshee Subject: Re: [PATCH 6/6] Input: elantech - add v3 hardware support Date: Fri, 19 Aug 2011 07:13:08 -0500 Message-ID: <20110819121308.GA16386@thinkpad-t410> References: <1313632629-23603-1-git-send-email-jj_ding@emc.com.tw> <1313632629-23603-7-git-send-email-jj_ding@emc.com.tw> <20110818173959.GE28313@thinkpad-t410> <87hb5ddcsa.fsf@emc.com.tw> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87hb5ddcsa.fsf@emc.com.tw> Sender: linux-kernel-owner@vger.kernel.org To: JJ Ding Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Aaron Huang , Tom Lin , Eric Piel , Daniel Kurtz , Chase Douglas , Henrik Rydberg , Alessandro Rubini List-Id: linux-input@vger.kernel.org On Fri, Aug 19, 2011 at 04:29:57PM +0800, JJ Ding wrote: > > You should only report the ABS_[XY] coordinates when fingers != 0. The > > xorg synaptics module sees the values reported in that case as > > legitimate. This is causing me to see strange behaviors when scrolling > > with two-finger drags. > AFAIK, though v2 and v3 differ in packet format, they really report the > same data to the userspace. In this version of v3 support, I even try to > make v2 and v3 report all the data in the same sequnce. If you're seeing > this issue, maybe we should do the same with v2? Actually neither v1 nor v2 reports ABS_[XY] unless fingers != 0. In v2 the reporting is in a switch statement on the number of fingers, and 0 is unhandled.