From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: michael.hennerich@analog.com
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Drivers <Drivers@analog.com>,
"device-drivers-devel@blackfin.uclinux.org"
<device-drivers-devel@blackfin.uclinux.org>
Subject: Re: [PATCH 3/4] Input: ad714x - use DMA-safe buffers for spi_write()
Date: Mon, 22 Aug 2011 09:39:17 -0700 [thread overview]
Message-ID: <201108220939.17702.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <4E5240F8.3050205@analog.com>
On Monday, August 22, 2011 04:43:52 AM Michael Hennerich wrote:
> On 08/21/2011 10:09 PM, Dmitry Torokhov wrote:
> > spi_write() requires use of DMA-safe (cacheline aligned) buffers.
> > Also use the same buffers when reading data since to avoid extra
> > locking and potential memory allocation in spi_write_then_read().
> >
> > Signed-off-by: Dmitry Torokhov<dtor@mail.ru>
>
> Looks good - one piece of the original patch set got lost.
Aww, sorry about that.
> See below - patch follows.
Thank you very much, I'll fold it in your original patch - no reason
for having a known broken change in the tree if it can be corrected.
--
Dmitry
next prev parent reply other threads:[~2011-08-22 16:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 20:09 [PATCH 1/4] Input: ad714xx-spi - force SPI bus into the default 8-bit mode Dmitry Torokhov
2011-08-21 20:09 ` [PATCH 2/4] Input: ad714x - fix endianness issues Dmitry Torokhov
2011-08-23 16:22 ` Mark Brown
2011-08-23 16:50 ` Dmitry Torokhov
2011-08-21 20:09 ` [PATCH 3/4] Input: ad714x - use DMA-safe buffers for spi_write() Dmitry Torokhov
2011-08-22 0:17 ` [Device-drivers-devel] " Mike Frysinger
2011-08-22 0:46 ` Dmitry Torokhov
2011-08-22 0:46 ` Dmitry Torokhov
2011-08-22 11:43 ` Michael Hennerich
2011-08-22 16:39 ` Dmitry Torokhov [this message]
2011-08-23 7:02 ` Hennerich, Michael
2011-08-21 20:09 ` [PATCH 4/4] Input: ad714x - read the interrupt status registers in a row Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108220939.17702.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=Drivers@analog.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).