From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chris Bagwell <chris@cnpbagwell.com>
Cc: linux-input@vger.kernel.org, Ping Cheng <pinglinux@gmail.com>,
Jaya Kumar <jayakumar.lkml@gmail.com>
Subject: Re: [PATCH 1/2] Input: wacom_w8001 - implement open and close
Date: Tue, 23 Aug 2011 10:48:31 -0700 [thread overview]
Message-ID: <20110823174831.GA25681@core.coreip.homeip.net> (raw)
In-Reply-To: <CAGzDe_bUbbpg5g773zhX__ax65jfVcRYf1afd=GxMS4GS8ge-w@mail.gmail.com>
On Tue, Aug 23, 2011 at 12:22:06PM -0500, Chris Bagwell wrote:
> I don't have one of these to test but anyways:
>
> Acked-by: Chris Bagwell <chris@cnpbagwell.com>
Thanks for looking at this. I don't have the hardware either so it would
be nice if someone who has it tried the patches...
>
> I've been trying to slowing document the protocols for ISDV4 and USB
> Wacom devices (http://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=ISDV4_Protocol
> for these ISDV4 ones if your interested). During this, I was
> comparing this version against the user land version of this driver
> inside xf86-input-wacom.
>
> xf86-input-wacom was doing a version of this patch so good to see
> here. The only other difference remaining is it also discards any
> data on the line during startup to flush old data from after initial
> STOP command and so that its sure of command/response sequence.
Hmm, I guess it indeed would be a good idea to reset w8001->idx in
w8001_open() to make sure we do not restart with buffer half-filled with
old data...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2011-08-23 17:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 20:15 [PATCH 1/2] Input: wacom_w8001 - implement open and close Dmitry Torokhov
2011-08-21 20:15 ` [PATCH 2/2] Input: wacom_w8001 - simplify w8001_remove Dmitry Torokhov
2011-08-23 17:22 ` [PATCH 1/2] Input: wacom_w8001 - implement open and close Chris Bagwell
2011-08-23 17:48 ` Dmitry Torokhov [this message]
[not found] ` <CAF8JNhJ+1=7J3e=Ohs-cpQVwkbYgqOfepxGt=MtWjXFq7=eHDQ@mail.gmail.com>
2011-08-23 21:23 ` Ping Cheng
2011-08-24 6:53 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823174831.GA25681@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chris@cnpbagwell.com \
--cc=jayakumar.lkml@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).