Re: [RFC/RFT][PATCH] Input: tsc2007 - convert to threaded IRQ

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Aug 25, 2011 at 09:52:54AM +0200, Thierry Reding wrote:
> * Dmitry Torokhov wrote:
> > On Thu, Aug 25, 2011 at 09:06:57AM +0200, Thierry Reding wrote:
> > > * Dmitry Torokhov wrote:
> > > > On Thu, Aug 25, 2011 at 08:21:59AM +0200, Thierry Reding wrote:
> > > > > * Dmitry Torokhov wrote:
> > > > > > This is completely untested but I believe it should work better than original
> > > > > > workqueue solution, especially when we do not have get_pendown_state method
> > > > > > available. I wonder if it will help Richard's issue with IRQ getting re-raised
> > > > > > after pen up event.
> > > > > > 
> > > > > > Anyone who has hardware - please give it a spin.
> > > > > 
> > > > > I can see no noticeable changes with this patch.
> > > > > 
> > > > 
> > > > That's the result I was aiming for ;) Thanks for testing.
> > > > 
> > > > Oh, crap... Does it still work if you change IRQ flags in
> > > > request_threaded_irq() from 0 to IRQF_ONESHOT? 
> > > > 
> > > > Also, while we are at it would you ming trying out another patch
> > > > (below)?
> > > 
> > > With both your patch applied and the change from 0 to IRQF_ONESHOT the driver
> > > oopses when loaded. I didn't have time to investigate further, but I think I
> > > could perhaps test a couple more patches if you provide them.
> > 
> > Hmm, can't spot the problem... Where does it die?
> 
> I'll see if I can track it down, but I have very limited time.

Don't worry, there is no rush whatsoever... I'll try to ponder the code
some more.

> 
> > If you could try just IRFQ_ONESHOT change that would be helpful.
> 
> With only just this change, things work okay.

Excellent, thanks.

-- 
Dmitry