From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: Axel Lin <axel.lin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"device-drivers-devel@blackfin.uclinux.org"
<device-drivers-devel@blackfin.uclinux.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input: adp5588-keys - remove incorrect modalias
Date: Fri, 26 Aug 2011 23:32:20 -0700 [thread overview]
Message-ID: <20110827063220.GD29434@core.coreip.homeip.net> (raw)
In-Reply-To: <544AC56F16B56944AEC3BD4E3D59177146E6D0708C@LIMKCMBX1.ad.analog.com>
On Thu, Aug 25, 2011 at 11:43:53AM +0100, Hennerich, Michael wrote:
> Axel Lin wrote on 2011-08-25:
> > From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
> > From: Axel Lin <axel.lin@gmail.com>
> > Date: Thu, 25 Aug 2011 18:26:56 +0800
> > Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias
> >
> > For i2c drivers, we should use "i2c:" prefix for modalias.
> > MODULE_DEVICE_TABLE will setup the modulalias for us,
> > thus adding a MODULE_ALIAS here seems redundant.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Applied, thanks Axel.
--
Dmitry
prev parent reply other threads:[~2011-08-27 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 10:30 [PATCH] Input: adp5588-keys - remove incorrect modalias Axel Lin
2011-08-25 10:43 ` Hennerich, Michael
2011-08-27 6:32 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110827063220.GD29434@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=axel.lin@gmail.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).