From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: adp5588-keys - remove incorrect modalias Date: Fri, 26 Aug 2011 23:32:20 -0700 Message-ID: <20110827063220.GD29434@core.coreip.homeip.net> References: <1314268238.2663.1.camel@phoenix> <544AC56F16B56944AEC3BD4E3D59177146E6D0708C@LIMKCMBX1.ad.analog.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-yi0-f46.google.com ([209.85.218.46]:46202 "EHLO mail-yi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865Ab1H0Gc0 (ORCPT ); Sat, 27 Aug 2011 02:32:26 -0400 Content-Disposition: inline In-Reply-To: <544AC56F16B56944AEC3BD4E3D59177146E6D0708C@LIMKCMBX1.ad.analog.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Hennerich, Michael" Cc: Axel Lin , "linux-kernel@vger.kernel.org" , "device-drivers-devel@blackfin.uclinux.org" , "linux-input@vger.kernel.org" On Thu, Aug 25, 2011 at 11:43:53AM +0100, Hennerich, Michael wrote: > Axel Lin wrote on 2011-08-25: > > From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001 > > From: Axel Lin > > Date: Thu, 25 Aug 2011 18:26:56 +0800 > > Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias > > > > For i2c drivers, we should use "i2c:" prefix for modalias. > > MODULE_DEVICE_TABLE will setup the modulalias for us, > > thus adding a MODULE_ALIAS here seems redundant. > > > > Signed-off-by: Axel Lin > > Acked-by: Michael Hennerich Applied, thanks Axel. -- Dmitry