From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Philip Langdale <philipl@overt.org>,
linux-input@vger.kernel.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: INPUT_COMPAT_TEST
Date: Wed, 7 Sep 2011 11:37:45 -0700 [thread overview]
Message-ID: <20110907183745.GB2874@core.coreip.homeip.net> (raw)
In-Reply-To: <4E67B652.5010406@zytor.com>
On Wed, Sep 07, 2011 at 11:22:10AM -0700, H. Peter Anvin wrote:
> On 09/07/2011 11:16 AM, Dmitry Torokhov wrote:
> > On Sat, Jul 09, 2011 at 01:04:53AM -0700, H. Peter Anvin wrote:
> >> On 07/08/2011 05:35 PM, Dmitry Torokhov wrote:
> >>>
> >>> Input only need to do this compat stuff on read/write paths so maybe if
> >>> you add plumbing similar to compat_ioctl we could switch owver to it.
> >>>
> >>
> >> The problem is that read/write ties into a large number of system calls,
> >> and input is the *only* subsystem which needs it.
> >>
> >
> > BTW, while listening to x32 resentation on LPC I realized that the need
> > for compat tests on read/write paths in input subsystem is due to use of
> > timeval in input_event structures. If x32 solved the time_t issue by
> > moving to 64 bit times then input read/write should simply use native
> > 64 bit operations.
> >
> > That still leaves sysfs and proc business of course...
> >
>
> I thought there were pointers, (or longs) there too.
>
> In fact, we might have had the worst of both worlds here...
>
The pointers are in ioctl paths (upload of force-feedback effects with
custom waveforms - noone actually uses them in real life).
--
Dmitry
next prev parent reply other threads:[~2011-09-07 18:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 18:45 INPUT_COMPAT_TEST H. Peter Anvin
2011-07-08 20:46 ` INPUT_COMPAT_TEST Dmitry Torokhov
2011-07-08 22:22 ` INPUT_COMPAT_TEST H. Peter Anvin
2011-07-08 22:37 ` INPUT_COMPAT_TEST Dmitry Torokhov
2011-07-08 22:44 ` INPUT_COMPAT_TEST Thadeu Lima de Souza Cascardo
2011-07-08 23:18 ` INPUT_COMPAT_TEST H. Peter Anvin
2011-07-09 0:35 ` INPUT_COMPAT_TEST Dmitry Torokhov
2011-07-09 8:04 ` INPUT_COMPAT_TEST H. Peter Anvin
2011-09-07 18:16 ` INPUT_COMPAT_TEST Dmitry Torokhov
2011-09-07 18:22 ` INPUT_COMPAT_TEST H. Peter Anvin
2011-09-07 18:37 ` Dmitry Torokhov [this message]
2011-09-07 18:40 ` INPUT_COMPAT_TEST H. Peter Anvin
2011-09-07 18:54 ` INPUT_COMPAT_TEST Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110907183745.GB2874@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-input@vger.kernel.org \
--cc=philipl@overt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).