From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: chris@cnpbagwell.com
Cc: linux-input@vger.kernel.org, pinglinux@gmail.com, rydberg@euromail.se
Subject: Re: [PATCH v2] Input: wacom - fix touch on newer Bamboo's
Date: Fri, 9 Sep 2011 13:41:12 -0700 [thread overview]
Message-ID: <20110909204112.GB9157@core.coreip.homeip.net> (raw)
In-Reply-To: <1315353406-8564-1-git-send-email-chris@cnpbagwell.com>
On Tue, Sep 06, 2011 at 06:56:46PM -0500, chris@cnpbagwell.com wrote:
> From: Chris Bagwell <chris@cnpbagwell.com>
>
> Bamboo's with Product ID's > 0xD4 return values unrelated to pressure
> in touch 1 pressure field. They also report touch 2's X/Y values
> shifted down 1 byte (where pressure was). This results in jumpy
> 1 finger touch and totally invalid 2nd finger data.
>
> For touch detection, switch to a Touch Present single bit that
> all versions of Bamboo support.
>
> For touch 2 offset, calculate offset based on a bit that is set
> different between the two packet layouts.
>
> Since touch pressure reports were removed from driver, there was
> no need to be reading pressure any more.
>
> Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
> Reviewed-by: Ping Cheng <pinglinux@gmail.com>
Applied, thanks Chris.
--
Dmitry
next prev parent reply other threads:[~2011-09-09 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 23:56 [PATCH v2] Input: wacom - fix touch on newer Bamboo's chris
2011-09-09 20:41 ` Dmitry Torokhov [this message]
2011-09-12 2:08 ` Chris Bagwell
2011-09-13 5:10 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909204112.GB9157@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chris@cnpbagwell.com \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).